Removing the app_startup method is wrong and a hack.
app_startup is there for a reason to provide late initialisation and is called
in a number of places.
What you need to do is to call it conditionally from initialise which may be
the safer fix.
It may need a bigger fix but that is for later.
Phill has proposed merging lp:~phill-ridout/openlp/bug1367141-2 into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1367141 in OpenLP: "Presentations/Images with same name gets the same
thumbnail"
https://bugs.launchpad.net/openlp/+bug/1367141
For more details
Thank you, it works :).
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1405172
Title:
author type words and music
Status in OpenLP - Worship Presentation Software:
Fix Committed
Bug description:
** Changed in: openlp
Milestone: None => 2.1.2
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1412234
Title:
bibles __init__.py
The proposal to merge lp:~phill-ridout/openlp/bug1412234-2 into lp:openlp has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1412234-2/+merge/247283
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
The proposal to merge lp:~phill-ridout/openlp/copyright-2 into lp:openlp has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247343
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247343
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
Review: Needs Fixing
Not convinced this is correct but no time to look tonight.
--
https://code.launchpad.net/~phill-ridout/openlp/bug1411433/+merge/247224
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/bug1412234-2/+merge/247283
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
U
Review: Needs Fixing
No print statements!
--
https://code.launchpad.net/~phill-ridout/openlp/bug1367141-2/+merge/247338
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/bug1411433/+merge/247224
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Uns
Hi Chris, thanks for your contribution! Right now we're currently trying to get
2.2 out the door, which means that we're concentrating on fixing all the bugs
and won't be adding any new features.
But don't worry, once 2.2 is out, we'll be picking up the feature merge
proposals again.
--
http
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247343
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
Phill has proposed merging lp:~phill-ridout/openlp/copyright-2 into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247343
Fixes the copyright headers
--
Your team OpenLP Core is subscribed to branch
Phill has proposed merging lp:~phill-ridout/openlp/copyright-2 into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247342
Fixes the copyright headers
--
Your team OpenLP Core is subscribed to branch
Phill has proposed merging lp:~phill-ridout/openlp/bug1367141-2 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1367141 in OpenLP: "Presentations/Images with same name gets the same
thumbnail"
https://bugs.launchpad.net/openlp/+bug/1367141
For more details,
** Branch linked: lp:~phill-ridout/openlp/bug1367141-2
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1367141
Title:
Presentations/Images with same name gets the same thumbnail
Status in OpenLP - Wo
Review: Needs Fixing
Should not remove python3 from scripts
--
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247332
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Phill has proposed merging lp:~phill-ridout/openlp/copyright-2 into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247332
Fixes the copyright headers
--
Your team OpenLP Core is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/bug1412234-2/+merge/247283
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
U
Review: Needs Fixing
You do not need python3 on the top of each file.
--
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247285
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp
This looks fine to me. It provides enough flexibility.
--
https://code.launchpad.net/~phill-ridout/openlp/bug1412234-2/+merge/247283
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/bug1412234-2 into lp:openlp.
___
** Branch linked: lp:~phill-ridout/openlp/bug1412234-2
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1412234
Title:
bibles __init__.py has interesting translation string
Status in OpenLP - Worship
Superseded by
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247285
--
https://code.launchpad.net/~phill-ridout/openlp/copyright/+merge/247223
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/copyright into lp:openlp.
___
Phill has proposed merging lp:~phill-ridout/openlp/copyright-2 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/copyright-2/+merge/247285
Fixes the copyright headers
--
Your team OpenLP Core is requested to rev
Phill has proposed merging lp:~phill-ridout/openlp/bug1412234-2 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1412234-2/+merge/247283
As per my proposal at:
https://code.launchpad.net/~phill-ridout/openlp
The diff isn't that clear what I've done. I removed the app_startup method and
moved the code that was in it up the file to the initialise method.
--
https://code.launchpad.net/~phill-ridout/openlp/bug1411433/+merge/247224
Your team OpenLP Core is requested to review the proposed merge of
lp:~ph
No that is unintentional, I'll fix it and resub.
--
https://code.launchpad.net/~phill-ridout/openlp/copyright/+merge/247223
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/copyright into lp:openlp.
___
Mailin
Should we translate everything to be on the safe side of things? There are
other languages far more exotic than matysek's (no offence intended).
--
https://code.launchpad.net/~phill-ridout/openlp/bug1412234/+merge/247207
Your team OpenLP Core is subscribed to branch lp:openlp.
__
> No, at least : and, need to be translated. Some languages use ; instead of :
: should be translated because in my language it is common to use
Psalm 1,1 = Psalm chapter 1 verse 1
Otherwise it looks fine to me.
--
https://code.launchpad.net/~phill-ridout/openlp/bug1412234/+merge/247207
You
Review: Needs Information
You are removing some declarations from pptviewlib.h - is that on purpose? Have
you tested that it still compiles?
--
https://code.launchpad.net/~phill-ridout/openlp/copyright/+merge/247223
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ri
Public bug reported:
See http://abcplus.sourceforge.net/ for details.
The project http://openhymnal.org/ uses this format.
** Affects: openlp
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to Op
At the moment the user has no chance to fix the problem without patching
the database directly. If 2.0.4 is more tolerant then 2.1.x, then the
user should at least have the possibility to fix the problem in the UI.
Two possible soutions:
1. Check the db for inconsistency when upgrading to 2.1.x. E
33 matches
Mail list logo
