Review: Needs Fixing
See below.
Diff comments:
>
> === modified file 'openlp/core/lib/screen.py'
> --- openlp/core/lib/screen.py 2015-12-31 22:46:06 +
> +++ openlp/core/lib/screen.py 2016-01-09 22:36:52 +
> @@ -224,7 +224,7 @@
> y = window.y() + (window.height() // 2)
>
The proposal to merge lp:~thelinuxguy/openlp/fix-song-import into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-song-import/+merge/282108
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Approve
--
https://code.launchpad.net/~thelinuxguy/openlp/fix-song-import/+merge/282108
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~thelinuxguy/openlp/fix-song-import into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-song-import/+merge/282108
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
--
https://code.launchpad.net/~thelinuxguy/openlp/fix-song-import/+merge/282108
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/fix-song-import into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/fix-song-import/+merge/282108
Fix SongImport
Ignore Case for versetags when importing Song
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282098
--
Your team OpenLP Core is subscribed to branch lp:op
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Tomas Groth (tomasgroth)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282107
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282095
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282095
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
The proposal to merge lp:~alisonken1/openlp/ticket-921817 into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282101
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282101
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
The proposal to merge lp:~alisonken1/openlp/ticket-921817 into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282101
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
** Changed in: openlp
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
** Changed in: openlp
Milestone: None => 2.3.2
** Changed in: openlp
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed
The proposal to merge lp:~raoul-snyman/openlp/song-select-fixes into lp:openlp
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/song-select-fixes/+merge/282102
--
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~raoul-snyman/openlp/remove_stylesheet into lp:openlp
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/remove_stylesheet/+merge/282103
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~raoul-snyman/openlp/remove_stylesheet into lp:openlp
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/remove_stylesheet/+merge/282103
--
Your team OpenLP Core is subscribed to branch lp:openlp
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/remove_stylesheet/+merge/282103
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/remove_stylesheet
into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/remove_stylesheet/+merge/282103
Remove the media manager stylesheet for now.
Add thi
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/song-select-fixes/+merge/282102
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.
Review: Approve
--
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282101
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
Thanks Raoul & Ken!
Fair call on the testing & good to see that fix already in the pipes.
Sorry to cause hassle & Looking forward to 2.4 :)
I'll delete this request.
--
https://code.launchpad.net/~ieknight1101/openlp/pjlink/+merge/281821
Your team OpenLP Core is subscribed to branch lp:openlp.
Ken Roberts has proposed merging lp:~alisonken1/openlp/ticket-921817 into
lp:openlp.
Requested reviews:
Tomas Groth (tomasgroth)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282101
Ticket 921817 - exception when connecting us
The proposal to merge lp:~alisonken1/openlp/ticket-921817 into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282100
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
No problem - I'll setup something and let you know.
--
https://code.launchpad.net/~alisonken1/openlp/test-projector/+merge/270902
Your team OpenLP Core is requested to review the proposed merge of
lp:~alisonken1/openlp/test-projector into lp:openlp.
__
Let's put it in another branch/repository then. Even if it just lives on your
account, that's fine.
--
https://code.launchpad.net/~alisonken1/openlp/test-projector/+merge/270902
Your team OpenLP Core is requested to review the proposed merge of
lp:~alisonken1/openlp/test-projector into lp:openlp
Hey Ian,
We've made it a policy that any code changes need at least 1 unit test with
them, however small. We're trying to increase our test coverage (from zero), so
any extra testing is most welcome.
I think that Ken Roberts also fixed the bug in another branch (he is the
original author of th
Review: Needs Fixing
See inline
Diff comments:
>
> === added file 'tests/functional/openlp_core_lib/test_projector_pjlink1.py'
> --- tests/functional/openlp_core_lib/test_projector_pjlink1.py
> 1970-01-01 00:00:00 +
> +++ tests/functional/openlp_core_lib/test_projector_pjlink1.py
See https://code.launchpad.net/~alisonken1/openlp/ticket-921817 for this fix
--
https://code.launchpad.net/~ieknight1101/openlp/pjlink/+merge/281821
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp
Review: Approve
--
https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282095
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
The proposal to merge lp:~alisonken1/openlp/ticket-921817 into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/281478
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Ken Roberts has proposed merging lp:~alisonken1/openlp/ticket-921817 into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/282100
Ticket 921817 - exception when connecting us
Review: Needs Fixing
You have print statements in the code
Why have you removed alerts from the Web page,
Not happy about just changing one form. Can we do that as a follow up later.
--
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282098
Your team OpenLP Core is su
I just checked, when a plugin is disabled (you can just replace the
songs.sqlite with a normal file)
The whole entry becomes disabled. So there really is no reason for the
dropdown. Currently the branch throws an Exception when a plugin is disabled,
but that can be fixed. What do you think?
--
The proposal to merge
lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into
lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282097
--
Your
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282098
Thanks Raoul!
I'm not sure at this stage how to approach writing tests for this merge due to
the reliance on a connected projector, however will verify that the issue is
resolved and post the results here when I gain access to the projector (which
is limited for me usually).
Would doing this an
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282096
--
Your team OpenLP Core is subscribed to branch lp:op
The proposal to merge
lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into
lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282097
--
Review: Approve
--
https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282095
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Un
Review: Approve
--
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282097
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282037
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282097
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
Need to update against head as you have conflicts.
find on +<<< TREE for details
--
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282096
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Simon Hanna has proposed merging lp:~thelinuxguy/openlp/make-methods-static
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/282096
Make some methods stati
Simon Hanna has proposed merging
lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282097
St
The proposal to merge lp:~thelinuxguy/openlp/make-methods-static into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281997
--
Your team OpenLP Core is subscribed to branch lp:op
The proposal to merge
lp:~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import into
lp:openlp has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thelinuxguy/openlp/strip-whitespace-from-titles-songbeamer-import/+merge/282037
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282081
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into
lp:openlp.
Commit message:
Add support for multiple songbooks
* Migrate DB schema
* Add listbox to song edit dialog and enlarge that dialog a bit
* Rename "Song Book" to "Songbook"
* In the search results, display one
** Changed in: openlp
Status: In Progress => Fix Committed
** Changed in: openlp
Milestone: None => 2.3.2
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1531319
Title:
The presentation di
** Branch linked: lp:openlp
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1531319
Title:
The presentation display isn't updated on windows
Status in OpenLP:
Fix Committed
Bug description:
Seen
The proposal to merge lp:~tomasgroth/openlp/importer-fixes into lp:openlp has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/importer-fixes/+merge/282093
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
The proposal to merge lp:~tomasgroth/openlp/importer-fixes into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tomasgroth/openlp/importer-fixes/+merge/282093
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
Looks fine to me
--
https://code.launchpad.net/~tomasgroth/openlp/importer-fixes/+merge/282093
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists
** Changed in: openlp
Status: New => In Progress
** Changed in: openlp
Assignee: (unassigned) => Tomas Groth (tomasgroth)
** Branch linked: lp:~tomasgroth/openlp/importer-fixes
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to Open
lp:~tomasgroth/openlp/importer-fixes (revision 2597)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1223/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1148/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1087/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_F
Tomas Groth has proposed merging lp:~tomasgroth/openlp/importer-fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1531319 in OpenLP: "The presentation display isn't updated on windows"
https://bugs.launchpad.net/openlp/+bug/1531319
For more details, see:
Looks to me as it is now working fine on Fedora.
Can OSX and Windows be checked so can be marked as Wontfix.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/848316
Title:
Highlight the current slide i
Are the first and last names actually used somewhere? (It might be the
searching, I didn't check)
Currently it is possible to add authors that only have one name. When
adding authors from the song edit form, the form doesn't enforce more
than one word. Adding one word there, just adds the text to
No not started
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1266270
Title:
OpenLP hides dialogs whe using "play slides in loop" on OSX
Status in OpenLP:
Confirmed
Status in OpenLP 2.0 series:
For me this looks like it's fixed in trunk...
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/848316
Title:
Highlight the current slide in the slidecontroller
Status in OpenLP:
Confirmed
Bug descr
Can someone confirm, that it's fixed in trunk?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1266270
Title:
OpenLP hides dialogs whe using "play slides in loop" on OSX
Status in OpenLP:
Confirmed
63 matches
Mail list logo
