Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1694430 in OpenLP: "Allow to show alternate title in footer"
https://bugs.launchpad.net/openlp/+bug/1694430
Bug
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325514
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
Blank lines!
Will review tomorrow as I have bible study!
Diff comments:
> === modified file 'openlp/core/lib/serviceitem.py'
> --- openlp/core/lib/serviceitem.py2017-05-17 20:06:45 +
> +++ openlp/core/lib/serviceitem.py2017-06-12 18:37:29 +
> @@ -276,12
> Cannot run this but there seem to be lots of line breaks in the footer
> display. As the footer area is small this will not be displayed and lead to
> forum comments.
The footer has the same height as before, there should be no difference by
default.
So I replaced Pystache with Mako. Should
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325043
--
Your team OpenLP Core is subscribed to branch lp:openlp.
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1694430 in OpenLP: "Allow to show alternate title in footer"
https://bugs.launchpad.net/openlp/+bug/1694430
Bug
I just tested on Fedora 25 (gnome shell) with python 3 and PyQt5
installed with the package manager and also on OS X El Capitan with
python 3 and PyQt5 installed with macPorts. On both systems it works
just fine.
Output:
`[['/home/jasperge/openlp_bug/#1234.xml',
7 matches
Mail list logo
