Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-f into lp:openlp.
Commit message:
PJLink class 2 update F
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2
The proposal to merge lp:~alisonken1/openlp/pjlink2-f into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-f/+merge/327052
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
oops - thought I removed those two lines.
I also remember running jenkins, but guess I forgot to delete the
previous run from the request.
On Wed, Jul 12, 2017 at 12:30 AM, Tomas Groth wrote:
> Review: Needs Fixing
>
> You left some commented code in, see the inline comment. Also please post the
Review: Needs Fixing
For the ArchLinux section I would leave out the part about pacaur and just link
to the OpenLP AUR page: https://aur.archlinux.org/packages/openlp/, "Arch'ers"
should know how to proceed from there. pacaur is just one of many AUR
client/helpers: https://wiki.archlinux.org/in
Review: Needs Fixing
You left some commented code in, see the inline comment. Also please post the
jenkins test result for the latest revision.
Otherwise it looks good to me.
Diff comments:
>
> === modified file 'openlp/core/lib/projector/pjlink1.py'
> --- openlp/core/lib/projector/pjlink1.py
5 matches
Mail list logo
