Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-13 Thread Tomas Groth
Review: Needs Information Which platforms have you tested this on? If I understand correctly the changes would effect both Linux, Windows and Mac OS. -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356675 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-13 Thread Ken Roberts
I spent some time trying to work with signals, but since signals have to be bound to be used, trying to get a signal connected from the projector code to the settings tab instance was convoluted and not as clean as the registry. The other consideration is how often will projector instances be

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-13 Thread Tim Bentley
Review: Needs Fixing There should be a better way than adding and removing functions from the registry. -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/356677 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] Linting: Passed

2018-10-13 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/356677 Your team OpenLP Core is requested to review the proposed merge of lp:~alisonken1/openlp/pjlink2-t into lp:openlp. ___ Mailing list:

[Openlp-core] Linux Test Results: Passed

2018-10-13 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/356677 Your team OpenLP Core is requested to review the proposed merge of lp:~alisonken1/openlp/pjlink2-t into lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-13 Thread Ken Roberts
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-t into lp:openlp. Commit message: PJLink2-T Update (UDP updates and some cleanups) Having network issues - ci failed when running ci but passed when looked at branch webpage:

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-13 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/setup into lp:openlp. Commit message: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.6 because this was agreed to on the mailing list. To overcome the module

[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

2018-10-13 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356602 -- Your team OpenLP Core is subscribed to branch lp:openlp.