Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/55/
for more details
--
https://code.launchpad.net/~raoul-snyman/openlp/pyro-impress/+merge/357862
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: http
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/pyro-impress into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/pyro-impress/+merge/357862
Add presentations through LibreOffice on macOS. Comments and critici
The proposal to merge lp:~raoul-snyman/openlp/pyro-impress into lp:openlp has
been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/pyro-impress/+merge/312480
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Needs Fixing
Just one small change.
Diff comments:
>
> === modified file 'launchpad-ppa/debian/rules'
> --- launchpad-ppa/debian/rules2012-11-21 21:29:26 +
> +++ launchpad-ppa/debian/rules2018-10-24 22:57:18 +
> @@ -18,4 +18,4 @@
> mkdir -p debian/openlp/us
The proposal to merge lp:~jelmer/openlp/vcs-field-uses-insecure-uri into
lp:openlp/debian-package has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~jelmer/openlp/vcs-field-uses-insecure-uri/+merge/354898
--
Your team OpenLP Core is subscribe
The proposal to merge lp:~jelmer/openlp/vcs-field-uses-insecure-uri into
lp:openlp/debian-package has been updated.
Commit message changed to:
Use secure URI in Vcs control header.
The lp: prefix gets expanded to http://code.launchpad.net/ for
users that are not logged in on some versions of Ba
Test coverage dropped below 50%, please see
https://ci.openlp.io/job/MP-05-Test-Coverage/3/ for more details
--
https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/qcollator into
^^ ignore those. it's failing on a test that should be running
--
https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/qcollator into lp:openlp.
___
Test coverage dropped below 50%, please see
https://ci.openlp.io/job/MP-05-Test-Coverage/1/ for more details
--
https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/qcollator into
Hey Bastian,
Can you just explain to me how the line you added to an otherwise "empty" file
solves the problem? I'm curious, as it doesn't make sense to me (even though it
clearly works!), and I'm confused :-(
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your
Linting passed!
--
https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/qcollator into lp:openlp.
___
Mailing list: https://launchpad.ne
Linux tests passed!
--
https://code.launchpad.net/~bastian-germann/openlp/qcollator/+merge/357851
Your team OpenLP Core is requested to review the proposed merge of
lp:~bastian-germann/openlp/qcollator into lp:openlp.
___
Mailing list: https://launchpa
Bastian Germann has proposed merging lp:~bastian-germann/openlp/qcollator into
lp:openlp.
Commit message:
Replace PyICU with PyQt's QCollator
Use QCollator as new collator to get rid of the PyICU dependency.
Simplify the natural sorting with its numeric mode.
Simplify one test that is heavily de
Linting passed!
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Linux tests passed!
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.
Bastian Germann has proposed merging lp:~bastian-germann/openlp/fix-circ-dep
into lp:openlp.
Commit message:
Fix a circular dependency that is hit when you run
tests.interfaces.openlp_plugins.custom.forms.test_customform:
ImportError: Failed to import test module:
tests.interfaces.openlp_plugi
The proposal to merge lp:~bastian-germann/openlp/fix-circ-dep into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357597
--
Your team OpenLP Core is subscribed to branch lp:openlp.
** Changed in: openlp/trunk
Milestone: None => 2.9.1
** Changed in: openlp/trunk
Status: In Progress => Fix Committed
** Changed in: openlp/trunk
Importance: Undecided => High
** Changed in: openlp/trunk
Assignee: (unassigned) => Bastian Germann (bastian-germann)
--
You rece
Review: Approve
--
https://code.launchpad.net/~bastian-germann/openlp/packaging/+merge/357789
Your team OpenLP Core is subscribed to branch lp:openlp/packaging.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launc
Review: Needs Fixing
Need to convert to a correct From statement. Blanket imports are not used in
openlp code.
--
https://code.launchpad.net/~bastian-germann/openlp/fix-circ-dep/+merge/357597
Your team OpenLP Core is subscribed to branch lp:openlp.
20 matches
Mail list logo
