[Openlp-core] [Merge] lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging

2019-05-02 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging. Commit message: Build a Windows Installer (MSI) file instead of using InnoSetup Requested reviews: Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.ne

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging

2019-05-02 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/wix-packaging into lp:openlp/packaging has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/wix-packaging/+merge/365880 -- Your team OpenLP Core is subscribed to branch lp:op

[Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread noreply
The proposal to merge lp:~bastian-germann/openlp/pymupdf into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Phill
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Uns

[Openlp-core] [Merge] lp:~tomasgroth/openlp/portable-path into lp:openlp

2019-05-02 Thread noreply
The proposal to merge lp:~tomasgroth/openlp/portable-path into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Tomas Groth
Review: Approve -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Uns

[Openlp-core] Linux Test Results: Passed

2019-05-02 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

[Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/pymupdf into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366835 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/pymupdf into lp:openlp. Commit message: Add PyMuPDF as additional PDF controller and missing mupdf file formats Requested reviews: Tomas Groth (tomasgroth) Phill (phill-ridout) For more details, see: https://code.launchpad.net/

[Openlp-core] Linting: Passed

2019-05-02 Thread Raoul Snyman
Linting passed! -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsub

[Openlp-core] macOS Test Results: Passed

2019-05-02 Thread Raoul Snyman
macOS tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366851 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

[Openlp-core] Linux Test Results: Passed

2019-05-02 Thread Raoul Snyman
Linux tests passed! -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366835 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Raoul Snyman
OK, I've installed PyMuPDF. -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366835 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchp

[Openlp-core] Linting: Failed

2019-05-02 Thread Raoul Snyman
Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/84/ for more details -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366835 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launch

[Openlp-core] Linux Test Results: Failed

2019-05-02 Thread Raoul Snyman
Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/137/ for more details -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366835 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Bastian Germann
@raoul-snyman Would you please install PyMuPDF for the test environment? -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366835 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp

[Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Bastian Germann
Bastian Germann has proposed merging lp:~bastian-germann/openlp/pymupdf into lp:openlp. Commit message: Add PyMuPDF as additional PDF controller and missing mupdf file formats Requested reviews: Tomas Groth (tomasgroth) Phill (phill-ridout) For more details, see: https://code.launchpad.net/

[Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Bastian Germann
The proposal to merge lp:~bastian-germann/openlp/pymupdf into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~trb143/openlp/more_media into lp:openlp

2019-05-02 Thread Tomas Groth
Review: Needs Fixing I tried running the branch on a windows system which I then realized didn't have VLC. But it resulted in this traceback: https://bin.snyman.info/mmmvuquw -- https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608 Your team OpenLP Core is subscribed to branch lp:op

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Tomas Groth
Could you please add the additional file types supported by mupdf: *.epub, *.cbz and *.fb2. These should also be added for the binary mupdf. -- https://code.launchpad.net/~bastian-germann/openlp/pymupdf/+merge/366749 Your team OpenLP Core is subscribed to branch lp:openlp. __

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/portable-path into lp:openlp

2019-05-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Un

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/pymupdf into lp:openlp

2019-05-02 Thread Phill
Review: Needs Fixing Ok, I'm happy with adding pymupdf, however, I've spoken to Tomas, and we think it would be better if pymupdf was in the first if block and then it would take precedence over the binary if pymupdf was installed. Also, can you add a test please? -- https://code.launchpad.net

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/portable-path into lp:openlp

2019-05-02 Thread Phill
Review: Approve Thanks -- https://code.launchpad.net/~tomasgroth/openlp/portable-path/+merge/366785 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.