Review: Needs Fixing
Please change your string formatting to use the 'new' style with the format
function. ( https://pyformat.info/ ) also string formatting is preferred over
concatenation (i.e, "part1" + var + "part2")
single quotes for strings, not double quotes
do_import_file is very long c
Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/206/
for more details
--
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/369653
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/fixes-III into lp:openlp.
___
Phill has proposed merging lp:~phill-ridout/openlp/fixes-III into lp:openlp.
Commit message:
Minor fixes and changes
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-III/+merge/369653
--
Your team OpenLP Core is requeste
3 matches
Mail list logo