Public bug reported:
System Info:
Windows 10 Pro x64 Build 1703
OpenLP 2.4.6
Steps to reproduce:
File / Import / CCLI SongSelect
(Login)
Search for a song e.g. 'All Heaven Declares'
Instead of showing all of the results in the correct order (via
https://ccli.songselect.com this currently returns
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortfix into lp:openlp.
Commit message:
Natural sort in Edit Song, Song Maintenance form; performance improvements in
sorting when performing various searches, extended unit tests
Requested reviews:
OpenLP Core (openlp-core)
For more
Revision 2647 is with extracted lambdas but fails with E731
Revision 2648 is with def but fails with E301 and E704
All tested with Jenkins
--
https://code.launchpad.net/~minkus/openlp/naturalsortfix/+merge/292101
Your team OpenLP Core is subscribed to branch lp:openlp.
___
I have def because Raoul asked me to extract the lambdas into the line above
for performance reasons
Doing this works but fails PEP8: 'E731 do not assign a lambda expression, use a
def'
Using a def also works but fails E301 and E704 unless I put a blank line before
each 'def' and split each ont
I think fixing this will involve putting a blank line before every 'def', and
splitting the 'def' onto two lines.
I can do this, but think the blank line looks very ugly...
--
https://code.launchpad.net/~minkus/openlp/naturalsortfix/+merge/292101
Your team OpenLP Core is subscribed to branch lp:
lp:~minkus/openlp/naturalsortfix (revision 2648)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1466/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1382/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1320/
[SUCCESS] https://ci.openl
Having a nightmare
1) If I implement your suggestion, I get:
E731 do not assign a lambda expression, use a def for pep8
2) If I fix this as per
http://stackoverflow.com/questions/25010167/e731-do-not-assign-a-lambda-expression-use-a-def,
def get_key(object): return get_natural_key(object.name
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortfix into lp:openlp.
Commit message:
Natural sort in Edit Song, Song Maintenance form; performance improvements in
sorting when performing various searches, extended unit tests
Requested reviews:
OpenLP Core (openlp-core)
For more
Haven't had time yet but will do once tests are written.
--
https://code.launchpad.net/~minkus/openlp/naturalsortfix/+merge/291024
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortfix into lp:openlp.
Commit message:
Natural sort in Edit Song, Song Maintenance form; performance improvements in
sorting when performing various searches
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortfix into lp:openlp.
Commit message:
Search performance tweaks when performing natural sort - author, songbook,
topic, theme, CCLI number search
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https
lp:~minkus/openlp/naturalsortfix (revision 2638)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1380/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1298/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1237/
[SUCCESS] https://ci.openl
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortsongs into
lp:openlp.
Commit message:
Fix bug #1280295 - 'Enable natural sorting for song book searches', refactors
for database querying
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1280295 in OpenL
Of course. I need some spare time to sort & test - then will do so. I've got a
slot this weekend :)
Chris
Sent from my iPhone
> On 31 Mar 2016, at 19:45, Raoul Snyman wrote:
>
> Hey Chris, can you make the change to use that other function and then
> resubmit your merge proposal? Then we can
No worries.
This works in most instances, but I get a crash, and I think it's when
get_natural_key is passed a blank string. I don't understand the relevant line
of get_natural_key well enough to fix it - help please?
Traceback (most recent call last):
File
"C:\Users\chris\Documents\OpenLP\n
I think I'll gracefully bow out for the time being - I think all of the edit
song box is 'default' sorting, but was particuarlly struggling with the
songbook searches as they mostly all involve numbers. But hopefully someone
else can adapt the _natural_sort_key function for other places!
--
htt
Is there anything else I need to do on this?
--
https://code.launchpad.net/~minkus/openlp/naturalsortsongs/+merge/289566
Your team OpenLP Core is requested to review the proposed merge of
lp:~minkus/openlp/naturalsortsongs into lp:openlp.
___
Mailing l
Sorry, coding standards issues (indentation only) resolved
lp:~minkus/openlp/naturalsortsongs (revision 2513)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1328/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1250/
[SUCCESS] https://ci.openlp.io/
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortsongs into
lp:openlp.
Commit message:
Fix bug 1280295 - 'Enable natural sorting for song book searches', refactors
for database querying
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1280295 in OpenL
Heya,
Do you mean if you have two topics assigned to one song, and the topic search
returns both instances? It will show both, sorted by topic then title, e.g.
(Search 'Thanking')
Thanking the Father (Song 1)
Thanking the Father (Song 2)
Thanking the Son (Song 1)
Thanking the Son (Song 3)
I tho
I've removed & recreated the merge proposal (as per
Branching_And_Merging_Standards) - please can this now be considered?
--
https://code.launchpad.net/~minkus/openlp/searchfields/+merge/286740
Your team OpenLP Core is requested to review the proposed merge of
lp:~minkus/openlp/searchfields into
lp:~minkus/openlp/searchfields (revision 2499)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1298/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1220/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1159/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functio
I tried running CI via jenkins_script.py yesterday and today but it keeps
giving me errors.
lp:~minkus/openlp/searchfields (revision 2499)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1291/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1215/
[SUCCESS] https://ci.openlp.io/job
Thanks Raoul. I've had to do learn quite a lot to get this sorted out (my
skills are sysadmin rather than dev) and don't have much spare time to commit -
just anxious not to have to resolve trunk conflicts again :) - but I understand
why releasing 2.4 matters!
Tim - I've learned a bit more abou
This is now ready for 2.4 - can it be merged?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1000729
Title:
Support more song fields in the search
Status in OpenLP:
In Progress
Status in OpenLP tr
Spent significant time updating to work with current trunk - can it go into 2.4?
--
https://code.launchpad.net/~minkus/openlp/searchfields/+merge/246954
Your team OpenLP Core is requested to review the proposed merge of
lp:~minkus/openlp/searchfields into lp:openlp.
_
Interestingly enough I had a go with a similar scenario in Windows 10
(using the built-in drivers) and it seemed to be OK.
I guess the Windows 8.1 default OpenGL renderer is different to the
Windows 10 one. It may be a Windows 8 only issue (which might mean it
goes away pretty quick?!? :)
Thanks
Public bug reported:
I recently upgraded a laptop to Windows 8.1 and experienced problems
starting up OpenLP.
After the initial setup phase, when attempting to start OpenLP. I got
the error "OpenLP has stopped working" and the application crashed. This
worked fine under Windows Vista.
After some
Now added unit tests. Ready for review.
--
https://code.launchpad.net/~minkus/openlp/naturalsortsongs/+merge/249699
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@l
All units now created for the search functions (not just mine), plus some extra
ones that I made.
Would appreciate feedback on this - do you need anything else? (this took quite
a lot of time!)
--
https://code.launchpad.net/~minkus/openlp/searchfields/+merge/246954
Your team OpenLP Core is requ
> Hey,
>
> - You should add a test.
> - Did you do any performance tests?
- Will do
- I've tested it on my database of 500-odd songs and it seems no slower than
normal. How should I do this, if you need more?
--
https://code.launchpad.net/~minkus/openlp/naturalsortsongs/+merge/249699
Your team
Now added doc strings (for all the search functions, not just mine).
Unit tests to follow - need more time for this! :)
--
https://code.launchpad.net/~minkus/openlp/searchfields/+merge/246954
Your team OpenLP Core is requested to review the proposed merge of
lp:~minkus/openlp/searchfields into l
** Branch linked: lp:~minkus/openlp/naturalsortsongs
** Changed in: openlp
Status: New => In Progress
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1280295
Title:
Enable natural sorting for
Chris Hill has proposed merging lp:~minkus/openlp/naturalsortsongs into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~minkus/openlp/naturalsortsongs/+merge/249699
Fixes bug 1280295 - 'Enable natural sorting for song book sea
** Changed in: openlp
Assignee: (unassigned) => Chris Hill (minkus)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1280295
Title:
Enable natural sorting for song book searches
Status in Ope
e, if anyone is in Christ, he is a new creation;
the old has gone, the new has come!' - 2 Corinthians 5v17
ch...@minkus.me.uk
-Original Message-
From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Phill
Sent: 26 January 2015 14:07
To: Chris Hill
Subject: Re: [Merge]
Hi Raoul - thanks. I'll keep working on the feature until you're ready. I think
it's mostly done now, just need to look at linked audio and make sure the rest
works. I couldn't find an Oxygen copyright icon so I made one myself (just the
symbol in a transparent PNG) - hope this is OK.
--
https:
Have implemented search for Copyright, CCLI - seems to be working fine
I'll look at Linked Audio later
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1000729
Title:
Support more song fields in the se
Regarding searching for Song Number, it is already possible to do this
using the 'Song Books' search (at least for me). Will look at the rest
shortly.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1000
Chris Hill has proposed merging lp:~minkus/openlp/searchfields into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1000729 in OpenLP: "Support more song fields in the search"
https://bugs.launchpad.net/openlp/+bug/1000729
For more details,
:( Any news on why this won't be fixed - even with your nice new Mac?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1247600
Title:
Stage View does not work on IPhone Safari
Status in OpenLP - Worsh
FYI - this still isn't working - solutions at present are a) install
Google Chrome for iOS (not ideal) or download the iOS OpenLP app from
https://itunes.apple.com/gb/app/openlp-remote/id730847052?mt=8 - this
works, but it costs money! :(
Would be nice for it to work properly on the 'default' brow
Having found & edited the above files in plugins\remotes\html, it
doesn't seem to be caused by this.
Looks like it might be because OpenLP is using an old version of JQuery
now - various other people online having problems with this, and if I
remove jquery.js completely from the above folder, all
** Attachment added: "Screenshot of stage view (see previous comment)"
https://bugs.launchpad.net/openlp/+bug/1247600/+attachment/3980786/+files/openlp-2.0.4-ios-7.0.4-stage-view.PNG
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
Also worth noting that files/stage.js and files/openlp.js also contain
the ö characters (as displayed by Google Chrome on Windows) so if it is
an issue with those it might need fixing in them too (referenced by the
Stage & OpenLP views)
--
You received this bug notification because you are a mem
Confirmed on OpenLP 2.0.4 (Windows Vista Business) and iOS 7.0.4 (iPad
3rd Gen, iPhone 4S) - neither the Remote nor the Stage View work
properly. They both worked fine in iOS 6, so it is a Safari bug - but
perhaps we could work around it?
Looks like the CSS file isn't read properly (see attached s
Public bug reported:
Windows 8.1 Pro / Windows Vista Business
OpenLP 2.0.4
We have a number of songs which have alphanumeric values for the
'Number' field (e.g. B23 or 119H - from our former praise supplement,
and also the Praise! hymnbook published in the UK in the late 90s).
Currently viewing
47 matches
Mail list logo
