[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-04-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Commit message: Make footer configurable Requested reviews: Tomas Groth (tomasgroth) Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-04-08 Thread Samuel Mehrbrodt
Merged trunk. I couldn't find a better way to do this without Mako or another template engine. -- https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/365702 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://laun

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-04-08 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Approved => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/363518 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-03-14 Thread Samuel Mehrbrodt
> Do you think it's plausible to just use string formatting or string > templating? Hm while that would allow adding a bit of markup around the strings, you can't add any control structures. With mako you can do much more, e.g. concatenate multiple authors into one line (as we do using join),

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-03-06 Thread Samuel Mehrbrodt
@Tim: As discussed on IRC, could you please review again? I had to remove the conditions so that the variables are always available to the template, even if they are empty. They were there to make sure that no empty lines were added to the footer. But now this checking is done in the template.

Re: [Openlp-core] [Merge] lp:~sam92/openlp/songbook-first-slide into lp:openlp

2019-02-21 Thread Samuel Mehrbrodt
Will add a test once I get the tests working again on my machine. -- https://code.launchpad.net/~sam92/openlp/songbook-first-slide/+merge/363538 Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/songbook-first-slide into lp:openlp. __

[Openlp-core] [Merge] lp:~sam92/openlp/songbook-first-slide into lp:openlp

2019-02-21 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/songbook-first-slide into lp:openlp. Commit message: Fix songbook as first slide display * Use same format as in footer * Only display publisher if it is set * Fix typo in settings Requested reviews: OpenLP Core (openlp-core) For more

[Openlp-core] [Merge] lp:~sam92/openlp/songbook-first-slide into lp:openlp

2019-02-21 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/songbook-first-slide into lp:openlp has been updated. Commit message changed to: Fix songbook as first slide display * Use same format as in footer * Only display publisher if it is set * Fix typo in settings For more details, see: https://code.launchpad.

[Openlp-core] [Bug 1470855] Re: Song title and author slide

2019-02-21 Thread Samuel Mehrbrodt
In trunk it's possible to enable a first slide which displays a songbook. We could expand that to add any information to the first slide by making it customizable, as done with the footer in bug 1695620. -- You received this bug notification because you are a member of OpenLP Core, which is subs

Re: [Openlp-core] [Merge] lp:~sam92/openlp/title-slide into lp:openlp

2019-02-21 Thread Samuel Mehrbrodt
I will close this MR. Tim implemented a similiar solution which allows showing the songbook as first slide. I guess we rather extend that solution than add options for everything. See bug 1470855. -- https://code.launchpad.net/~sam92/openlp/title-slide/+merge/216615 Your team OpenLP Core is subs

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-02-21 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/362915 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-02-21 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Commit message: Make footer configurable Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Tomas Groth (tomasgroth) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-02-08 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325552 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-02-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Commit message: Make use of Mako for footer generation being configurable in song settings Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #1694430 in OpenLP: "All

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2019-02-08 Thread Samuel Mehrbrodt
So is there a chance this can be reviewed now? > Blank lines! What do you mean with that? -- https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325552 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad

[Openlp-core] [Bug 1694430] Re: Allow to show alternate title in footer

2019-02-08 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) ** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1694430

[Openlp-core] [Bug 1695620] Re: Make footer elements customizable

2019-02-08 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) ** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1695620

[Openlp-core] [Bug 1809449] [NEW] Slide with more than three optional breaks are cut off

2018-12-21 Thread Samuel Mehrbrodt
Public bug reported: Create a slide (either song or custom presentation) and insert some text with more than three optional splits. After the third split everything is ignored, only three slides are generated. ** Affects: openlp Importance: Undecided Status: New -- You received t

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-13 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/169

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-13 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325533 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/169

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325514 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
> Cannot run this but there seem to be lots of line breaks in the footer > display. As the footer area is small this will not be displayed and lead to > forum comments. The footer has the same height as before, there should be no difference by default. So I replaced Pystache with Mako. Should

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1695620 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1695620/+merge/325043 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-12 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/169

Re: [Openlp-core] [Merge] lp:~samothjtm/openlp/bug-1695587 into lp:openlp

2017-06-08 Thread Samuel Mehrbrodt
Review: Approve -- https://code.launchpad.net/~samothjtm/openlp/bug-1695587/+merge/325118 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsub

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1695620 into lp:openlp

2017-06-04 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1695620 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1694430 in OpenLP: "Allow to show alternate title in footer" https://bugs.launchpad.net/openlp/+bug/1694430 Bug #1695620 in Ope

[Openlp-core] [Bug 1695620] [NEW] Make footer elements customizable

2017-06-03 Thread Samuel Mehrbrodt
Public bug reported: This mainly applies for the Songs footer. The footer can become very large if you have multiple authors, songbook info, CCLI license etc. Also you might want to display some parts of the footer larger than others (title vs copyright) -> HTML should be allowed So you should

[Openlp-core] [Bug 991348] Re: Display CCLI song number in footer

2017-06-03 Thread Samuel Mehrbrodt
Closing per comment #2 ** Changed in: openlp Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/991348 Title: Display CCLI song number in footer Status in OpenLP:

[Openlp-core] [Bug 1695587] Re: Entire Song doesn't search Song Number

2017-06-03 Thread Samuel Mehrbrodt
** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1695587 Title: Entire Song doesn't search Song Number Status in OpenLP: In Progress Bug d

[Openlp-core] [Bug 1546530] Re: Can we have an 'Altered By' author type?

2017-06-01 Thread Samuel Mehrbrodt
Created an issue in OpenLyrics for this: https://github.com/openlyrics/openlyrics/issues/39 ** Bug watch added: github.com/openlyrics/openlyrics/issues #39 https://github.com/openlyrics/openlyrics/issues/39 ** Changed in: openlp Status: New => Confirmed -- You received this bug notifi

[Openlp-core] [Bug 1694428] Re: Allow to hide CCLI number per song in footer

2017-06-01 Thread Samuel Mehrbrodt
Maybe we don't need an additional setting for this. We could show the CCLI license only if a "CCLI song number" has been entered in the song editor. ** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is

[Openlp-core] [Bug 1666006] Re: Song Editor alway saves theme

2017-06-01 Thread Samuel Mehrbrodt
** Changed in: openlp Status: New => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1666006 Title: Song Editor alway saves theme Status in OpenLP: Fix Released Bug description

[Openlp-core] [Bug 1694430] [NEW] Allow to show alternate title in footer

2017-05-30 Thread Samuel Mehrbrodt
Public bug reported: Add an option to the songs settings, off by default. ** Affects: openlp Importance: Wishlist Status: New ** Changed in: openlp Importance: Undecided => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscri

[Openlp-core] [Bug 1694428] [NEW] Allow to hide CCLI number per song in footer

2017-05-30 Thread Samuel Mehrbrodt
Public bug reported: When entering a CCLI number in the settings, it is shown in every song in the footer. Some songs might be covered by another license, so it makes no sense to show the CCLI license # in that case. There should be a way to define for each song whether it is necessary to show t

[Openlp-core] [Bug 1625087] [NEW] Image insertion doesn't respect natural order

2016-09-19 Thread Samuel Mehrbrodt
Public bug reported: When inserting images (when creating a image slideshow in OpenLP) with filenames like 1.jpg 2.jpg 3.jpg ... 10.jpg 11.jpg They don't get inserted in their natural order. Instead they are inserted like 10.jpg 11.jpg 1.jpg 2.jpg 3.jpg ... ** Affects: openlp Importance:

[Openlp-core] [Bug 1543947] Re: No Shortcuts work in 2.3.3 (only if i delete the alternative shortcut)

2016-04-29 Thread Samuel Mehrbrodt
This must have been fixed for 2.4. Please reopen if the issue still exists. ** Changed in: openlp Status: New => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1543947 Title: No

[Openlp-core] [Bug 1554815] Re: Songbook number ordering fails

2016-04-29 Thread Samuel Mehrbrodt
*** This bug is a duplicate of bug 1552563 *** https://bugs.launchpad.net/bugs/1552563 ** This bug has been marked a duplicate of bug 1552563 Performance regression: Search by songbook very slow -- You received this bug notification because you are a member of OpenLP Core, which is subscr

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563-2.4 into lp:openlp/2.4

2016-04-29 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1552563-2.4 into lp:openlp/2.4 has been updated. Description changed to: Fix performance regression with Songbook search The problem was that in each iteration the database was accessed (the song object). Fixed this by loading all neccessary informati

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563-2.4 into lp:openlp/2.4

2016-04-29 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1552563-2.4 into lp:openlp/2.4. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1552563 in OpenLP: "Performance regression: Search by songbook very slow" https://bugs.launchpad.net/openlp/+bug/1552563

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563-2.4 into lp:openlp/2.4

2016-04-29 Thread Samuel Mehrbrodt
lp:~sam92/openlp/bug-1552563-2.4 (revision 2629) [SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1510/ [SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1421/ [SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1359/ [SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Funct

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563 into lp:openlp

2016-04-29 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1552563 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1552563 in OpenLP: "Performance regression: Search by songbook very slow" https://bugs.launchpad.net/openlp/+bug/1552563 For more de

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563 into lp:openlp

2016-04-29 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1552563 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1552563/+merge/293424 -- Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/o

Re: [Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563 into lp:openlp

2016-04-29 Thread Samuel Mehrbrodt
lp:~sam92/openlp/bug-1552563 (revision 2659) [SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1508/ [SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1419/ [SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1357/ [SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functiona

[Openlp-core] [Bug 1552563] Re: Performance regression: Search by songbook very slow

2016-04-29 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1552563 Title: Performance regression: Search by songbook very s

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1552563 into lp:openlp

2016-04-29 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1552563 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1552563 in OpenLP: "Performance regression: Search by songbook very slow" https://bugs.launchpad.net/openlp/+bug/1552563 For more de

Re: [Openlp-core] [Merge] lp:~minkus/openlp/naturalsortfix into lp:openlp

2016-04-15 Thread Samuel Mehrbrodt
You probably need to resubmit this proposal when you fixed the errors mentioned -- https://code.launchpad.net/~minkus/openlp/naturalsortfix/+merge/291024 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~o

[Openlp-core] [Bug 1557579] Re: Make the song-footer text "Written by" optional

2016-03-19 Thread Samuel Mehrbrodt
"Written by" is used when no author type has been given - should we rather just prefix it with "Author" in that case? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1557579 Title: Make the song-foote

[Openlp-core] [Bug 1552563] [NEW] Performance regression: Search by songbook very slow

2016-03-02 Thread Samuel Mehrbrodt
Public bug reported: Searching by songbook is very slow on large databases (~1000 songs) since the recent changes to support multiple songbooks. Ref: http://forums.openlp.org/discussion/2917/search-by-songbook/p1 ** Affects: openlp Importance: High Status: Confirmed ** Changed in:

[Openlp-core] [Bug 1546530] Re: Can we have an 'Altered By' author type?

2016-02-17 Thread Samuel Mehrbrodt
Would need an extension of OpenLyrics. These types are defined there. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1546530 Title: Can we have an 'Altered By' author type? Status in OpenLP: New

[Openlp-core] [Bug 1545072] [NEW] Translation issues

2016-02-12 Thread Samuel Mehrbrodt
Public bug reported: The string in openlp/plugins/songs/lib/importers/wordsofworship.py:109 appears as following on Transifex: Invalid Words of Worship song file. Missing "%s" header.WoW File\nSong Words The "WoW File\nSong Words" part should be inserted where the %s is and not appear in Transif

[Openlp-core] [Bug 1543603] Re: Unable to delete songs or custom slides

2016-02-09 Thread Samuel Mehrbrodt
** Changed in: openlp Importance: Undecided => High -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1543603 Title: Unable to delete songs or custom slides Status in OpenLP: New Bug description:

[Openlp-core] [Bug 1537212] Re: Song book number input box - not clearing and unexpected 'Enter' action

2016-01-30 Thread Samuel Mehrbrodt
** Changed in: openlp Status: Confirmed => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1537212 Title: Song book number input box - not clearing and unexpected 'Enter' action

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1537212 into lp:openlp

2016-01-30 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1537212 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1537212 in OpenLP: "Song book number input box - not clearing and unexpected 'Enter' action" https://bugs.launchpad.net

[Openlp-core] [Bug 1537212] Re: Song book number input box - not clearing and unexpected 'Enter' action

2016-01-29 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1537212 Title: Song book number input box - not clearing and unexpec

[Openlp-core] [Bug 1536411] Re: Verse order textbox jumps to end

2016-01-20 Thread Samuel Mehrbrodt
Ouch... Thanks for the report. Will try to fix that. Must be a regression from http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/2592 ** Changed in: openlp Importance: Undecided => High ** Changed in: openlp Milestone: None => 2.4.0 ** Changed in: openlp Status: New =

[Openlp-core] [Bug 1533081] Re: Importing Song DB fails

2016-01-17 Thread Samuel Mehrbrodt
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1533081 Title: Importing Song DB fails Status in OpenLP: Fix Committed Bug descrip

[Openlp-core] [Bug 1534306] Re: Empty song-titles causes tracebacks on update from 2.0 to 2.2

2016-01-17 Thread Samuel Mehrbrodt
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1534306 Title: Empty song-titles causes tracebacks on update from 2.0 to 2.2 Status i

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1533081 into lp:openlp

2016-01-17 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/bug-1533081 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~sam92/openlp/bug-1533081/+merge/282817 -- Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~sam92/openlp/bug-1533081 into lp:openlp

2016-01-15 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bug-1533081 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1533081 in OpenLP: "Importing Song DB fails" https://bugs.launchpad.net/openlp/+bug/1533081 Bug #1534306 in OpenLP: "Empty son

[Openlp-core] [Bug 1533081] Re: Importing Song DB fails

2016-01-15 Thread Samuel Mehrbrodt
** Changed in: openlp Status: Confirmed => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1533081 Title: Importing Song DB fails Status in OpenLP: In Progress Bug description:

[Openlp-core] [Bug 1534306] Re: Empty song-titles causes tracebacks on update from 2.0 to 2.2

2016-01-15 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) ** Changed in: openlp Milestone: None => 2.4.0 ** Changed in: openlp Status: Confirmed => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subs

[Openlp-core] [Bug 1534491] [NEW] Rename "OpenLP" importer to avoid confusion

2016-01-15 Thread Samuel Mehrbrodt
Public bug reported: Maybe we could rename the "OpenLP" importer to "OpenLP Song Database" to avoid confusion with OpenLyrics files. ** Affects: openlp Importance: Low Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to

[Openlp-core] [Bug 1533081] Re: Importing Song DB fails

2016-01-14 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1533081 Title: Importing Song DB fails Status in OpenLP: Confir

[Openlp-core] [Bug 1533081] [NEW] Importing Song DB fails

2016-01-11 Thread Samuel Mehrbrodt
Public bug reported: After rev. 2600, importing a Song DB fails. This is because the db schema has changed (multiple songbooks supported now). Need to either run migrations first on the imported db or find another way to fix this. ** Affects: openlp Importance: High Status: Confirm

[Openlp-core] [Bug 1066323] Re: Add song to multiple song books

2016-01-11 Thread Samuel Mehrbrodt
Fixed with http://bazaar.launchpad.net/~openlp- core/openlp/trunk/revision/2600 ** Changed in: openlp/trunk Assignee: (unassigned) => Samuel Mehrbrodt (sam92) ** Changed in: openlp/trunk Milestone: None => 2.4.0 ** Changed in: openlp/trunk Status: Confirmed => Fix

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-09 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282081 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-09 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Commit message: Add support for multiple songbooks * Migrate DB schema * Add listbox to song edit dialog and enlarge that dialog a bit * Rename "Song Book" to "Songbook" * In the sea

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Commit message: Add support for multiple songbooks * Migrate DB schema * Add listbox to song edit dialog and enlarge that dialog a bit * Rename "Song Book" to "Songbook" * In the sea

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-08 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/282000 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-08 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Commit message: Add support for multiple songbooks * Migrate DB schema * Add listbox to song edit dialog and enlarge that dialog a bit * Rename "Song Book" to "Songbook" * In the sea

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-08 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/281935 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-07 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Commit message: Add support for multiple songbooks * Migrate DB schema * Add listbox to song edit dialog and enlarge that dialog a bit * Rename "Song Book" to "Songbook" * In the sea

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-07 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/281646 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Bug 1530340] Re: Ctrl-F should select all text in the search field

2016-01-05 Thread Samuel Mehrbrodt
** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530340 Title: Ctrl-F should select all text in the search field Status in OpenLP: In Progres

[Openlp-core] [Bug 1530354] Re: Allow entering verse order in lowercase

2016-01-05 Thread Samuel Mehrbrodt
** Changed in: openlp Status: New => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530354 Title: Allow entering verse order in lowercase Status in OpenLP: In Progress Bug des

[Openlp-core] [Merge] lp:~sam92/openlp/bugs into lp:openlp

2016-01-05 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/bugs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1530340 in OpenLP: "Ctrl-F should select all text in the search field" https://bugs.launchpad.net/openlp/+bug/1530340 Bug #1530354 in Open

[Openlp-core] [Bug 1530354] Re: Allow entering verse order in lowercase

2016-01-05 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530354 Title: Allow entering verse order in lowercase Status in Ope

[Openlp-core] [Bug 1530340] Re: Ctrl-F should select all text in the search field

2016-01-05 Thread Samuel Mehrbrodt
** Changed in: openlp Assignee: (unassigned) => Samuel Mehrbrodt (sam92) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1530340 Title: Ctrl-F should select all text in the search field Sta

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-05 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Commit message: Add support for multiple songbooks * Migrate DB schema * Add listbox to song edit dialog and enlarge that dialog a bit * Rename "Song Book" to "Songbook" * In the sea

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-05 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/281582 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-05 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Commit message: Add support for multiple songbooks * Migrate DB schema * Add listbox to song edit dialog and enlarge that dialog a bit * Rename "Song Book" to "Songbook" * In the sea

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-05 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/multiple-songbooks into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/281542 -- Your team OpenLP Core is requested to review the proposed merge o

[Openlp-core] [Merge] lp:~sam92/openlp/multiple-songbooks into lp:openlp

2016-01-04 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/multiple-songbooks into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/multiple-songbooks/+merge/281542 Add support for multiple songbooks Currently there is still

[Openlp-core] [Bug 1530354] [NEW] Allow entering verse order in lowercase

2015-12-31 Thread Samuel Mehrbrodt
Public bug reported: When entering a verse order in lowercase (v1 c1 v2 c1), there is an error about unknown verse names. They should be automatically converted to uppercase and no complain should be given if they are valid in uppercase. ** Affects: openlp Importance: Wishlist Sta

[Openlp-core] [Bug 1530345] [NEW] Display comment in preview/live panel

2015-12-31 Thread Samuel Mehrbrodt
Public bug reported: Comments can be entered in the edit dialog, which can be used to add helpful information for the presenter. However, there is no way to see whether a song has comments from the default view. I suggest adding a tooltip icon next to the song title in the preview&live panel wh

[Openlp-core] [Bug 1530340] [NEW] Ctrl-F should select all text in the search field

2015-12-31 Thread Samuel Mehrbrodt
Public bug reported: When pressing Ctrl-F, the cursor jumps to the search field. To allow immediate searching, all existing text should be selected (Firefox and LibreOffice do the same for example). ** Affects: openlp Importance: Wishlist Status: New -- You received this bug noti

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fixes22 into lp:openlp. Requested reviews: Tim Bentley (trb143) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280925 Small fixes:   * Multiple '%s' in one string need t

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/fixes22 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280924 -- Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fixes22 into lp:openlp. Requested reviews: Tim Bentley (trb143) Tomas Groth (tomasgroth) For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280924 Small fixes:   * Multiple '%s' in one string need t

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
There are still remaining pep8 errors, but unrelated to my changes. Should I fix them also? CI Output is in the merge description. -- https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280924 Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/fixes22 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280922 -- Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/fixes22 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280850 -- Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fixes22 into lp:openlp. Requested reviews: Tomas Groth (tomasgroth) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280922 Small fixes:   * Multiple '%s' in one string need t

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fixes22 into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280850 Small fixes:   * Multiple '%s' in one string need to be named for tr

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-17 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/fixes22 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280252 -- Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-10 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fixes22 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/280252 Small fixes:   * Multiple '%s' in one string need to be named for tr

[Openlp-core] [Merge] lp:~sam92/openlp/fixes22 into lp:openlp

2015-12-10 Thread Samuel Mehrbrodt
The proposal to merge lp:~sam92/openlp/fixes22 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~sam92/openlp/fixes22/+merge/269170 -- Your team OpenLP Core is requested to review the proposed merge of lp:~sam92/openlp/fix

[Openlp-core] [Bug 1489338] Re: Windows Installer: Wrong default start menu name

2015-08-27 Thread Samuel Mehrbrodt
** Attachment added: "installer wrong name.PNG" https://bugs.launchpad.net/openlp/+bug/1489338/+attachment/4453243/+files/installer%20wrong%20name.PNG -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/

[Openlp-core] [Bug 1489338] [NEW] Windows Installer: Wrong default start menu name

2015-08-27 Thread Samuel Mehrbrodt
Public bug reported: When installing OpenLP 2.1.6, using the Windows installer, it suggests the start menu folder "OpenLP 2.0.4". This should be "OpenLP 2" or something like that instead. ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification b

  1   2   3   4   5   6   >