Re: [Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-04 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95757 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-04 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95757 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-03 Thread rimach
The proposal to merge lp:~crichter/openlp/bug-927816 into lp:openlp has been updated. Commit Message changed to: If a supported media player is not available, now the entry in the settings tab is greyed out instead of hidden. For more details, see:

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-03 Thread Jonathan Corwin
Review: Needs Information Is there a reason you did self.mediaPlayers[mediaPlayer].check_available() == False rather than not self.mediaPlayers[mediaPlayer].check_available() ? -- https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95693 Your team OpenLP Core is subscribed to

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-03 Thread rimach
No special reason. Doe I have to change it? -- https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95693 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-03 Thread Jonathan Corwin
Review: Needs Fixing Yes please. It would keep it consistent, especially since the previous line contains a 'not' -- https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95693 Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-03 Thread rimach
rimach has proposed merging lp:~crichter/openlp/bug-927816 into lp:openlp. Requested reviews: Tim Bentley (trb143) Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95757 fix for bug #927816 - correct condition --

[Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-02 Thread rimach
rimach has proposed merging lp:~crichter/openlp/bug-927816 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95693 fix for bug #927816 --

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bug-927816 into lp:openlp

2012-03-02 Thread Tim Bentley
Review: Approve Can we have a description in the merge request not just a link -- https://code.launchpad.net/~crichter/openlp/bug-927816/+merge/95693 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: