This is redundant now m2j has included it in his refactoring branch.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/95676
Your team OpenLP Core is requested to review the proposed merge of
lp:~crichter/openlp/bugfixing into lp:openlp.
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/95676
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/95676
Your team
Two things:
First you assign a new action to previousItem and nextItem. Therefore you loose
the pointer to the original one. This wouldn't cause functional problems, but
is not really transparent and it is unnecessary.
Secondly I have a running merge request, where I change all those code lines.
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/95676
Bug #943919 fixed
--
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347
Your team
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347
Your team OpenLP
Review: Approve
Tested on Fedora 16 - we have webkit working again!
Text over video with webkit now works fine
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
Jon Tibble (meths)
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49865
- change call for openoffice to soffice (additionally are necessary for
libreoffice)
- so
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49865
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49865
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49865
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49865
Your team
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49717
- change call for openoffice to soffice
- so hopefully it will work for all versions
Review: Needs Fixing
Need to fix:
Incorrect alignment lines 69 and 74.
Question rather than saying fix:
Are those new quotes in the connections deliberate and necessary then?
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49717
Your team OpenLP Core is subscribed to branch
Jon the Quotes are necessary
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/49717
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Approved
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44711
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44711
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44711
Your team
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44711
- Correct Signal slot connection for SongAddFromServiceCheckBox
- many Songbeamer
Review: Approve
Looks OK to me.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44711
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
As m2j said, please just handle the case where there are no verses. Thanks.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44196
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
- Correct Signal slot connection for SongAddFromServiceCheckBox
- many Songbeamer Files dont use the title flag, instead of this they use the
file name as title
--
Will this change to the SongBeamer import only fall back to the file name if
the title flag is not present? At the moment it doesn't look like that.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44196
Your team OpenLP Core is requested to review the proposed merge of
Will this change to the SongBeamer import only fall back to the file name if
the title flag is not present? At the moment it doesn't look like that.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44196
Your team OpenLP Core is requested to review the proposed merge of
(Sorry for the double-comment, I got an error the first time)
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44196
Your team OpenLP Core is requested to review the proposed merge of
lp:~crichter/openlp/bugfixing into lp:openlp.
___
Just saw: it is a fall back as the tags are parsed later. But when looking in
the code I didn't found a expression to handle the case of no verses. Would be
great if you could skip the import for those files. Just to make sure, that
each song has a verse and a title.
--
Review: Approve
Looks OK for me
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36474
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36356
Your team OpenLP Core is subscribed to branch lp:openlp.
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
fix click/unclick 'Auto detect', fix saving of language setting
add pinging of review page in translation_util.py
--
Review: Needs Fixing
line 23 Please add the name of your language here - That's the English, not
sure from the diff of the context so may want some punctuation.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36356
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
Greek to me !
Approved
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36201
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36201
Your team OpenLP Core is subscribed to branch lp:openlp.
sorry, problem while uploading. See changes in translation_utils.py
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36203
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36203
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36206
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Merged
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/36206
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35932
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35933
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Approved
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35933
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Approved = Merged
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35933
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Suggest you move the openlp.pyw fix in here as well as getting a bug fix in
will be easier than leaving it with the i18n stuff
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35588
Your team OpenLP Core is subscribed to branch lp:openlp.
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Jonathan Corwin (j-corwin)
change using of pipe instead of socket for soffice communication via uno.
--
Review: Approve
This looks fine, though I'm not sure that we really need to differentiate
between sockets and pipes.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35743
Your team OpenLP Core is subscribed to branch lp:openlp.
___
This looks fine, though I'm not sure that we really need to differentiate
between sockets and pipes.
I'm also not sure, but I think would can remove it later, if we really want to
use only one variant.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35743
Your team OpenLP Core
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
change using of pipe instead of socket for soffice communication via uno.
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35588
Your team OpenLP Core is
Review: Needs Fixing
This does not look correct.
Your connection strings will end up looking like this:
openoffice.org -nologo -norestore -minimized -invisible -nofirststartwizard
-accept=pipe,name=openlp_pipe:socket,host=localhost,port=2002;urp;
and
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Needs review = Approved
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/28244
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~crichter/openlp/bugfixing into lp:openlp has been
updated.
Status: Approved = Merged
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/28244
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
Approved
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/28222
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Approved
--
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/28244
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
49 matches
Mail list logo
