[Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-11 Thread Erik Lundin
Erik Lundin has proposed merging lp:~erik-lundin/openlp/bug-1053654 into lp:openlp. Requested reviews: Andreas Preikschat (googol) Raoul Snyman (raoul-snyman) Related bugs: Bug #1053654 in OpenLP: Adding verses from multiple chapters fails https://bugs.launchpad.net/openlp/+bug/1053654

Re: [Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-11 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~erik-lundin/openlp/bug-1053654/+merge/129285 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-10 Thread Raoul Snyman
Review: Needs Fixing 74 + from openlp.plugins.bibles.lib import LanguageSelection, \ 75 + BibleStrings Is there a particular reason you couldn't put this at the top of the file? 79 + for character in u'\\.^$*+?{}[]()': I know this isn't your code, but could you please just make

Re: [Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-08 Thread Raoul Snyman
Review: Needs Fixing Line 121 and 122 below: You can put the function on the previous line, it still fits into 80 chars: book_ref_id = self.db_cache[bible].get_book_ref_id_by_localised_name( -- https://code.launchpad.net/~erik-lundin/openlp/bug-1053654/+merge/127123 Your team OpenLP Core

[Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-08 Thread Erik Lundin
Erik Lundin has proposed merging lp:~erik-lundin/openlp/bug-1053654 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Andreas Preikschat (googol) Related bugs: Bug #1053654 in OpenLP: Adding verses from multiple chapters fails https://bugs.launchpad.net/openlp/+bug/1053654

Re: [Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-08 Thread Erik Lundin
Raoul: Sure it does. Fixed now. -- https://code.launchpad.net/~erik-lundin/openlp/bug-1053654/+merge/128580 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-02 Thread Andreas Preikschat
Review: Needs Information Why do you return False in line 105? Shouldn't that rather be -1? -- https://code.launchpad.net/~erik-lundin/openlp/bug-1053654/+merge/127123 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-10-02 Thread Erik Lundin
Why do you return False in line 105? Shouldn't that rather be -1? I based that on line 42 in __init__.py. Honestly I haven't considered that too much, so it is possible that invalid values of book_ref_id should be represented differently. I basically broke out that part of the code and put in

[Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-09-29 Thread Erik Lundin
Erik Lundin has proposed merging lp:~erik-lundin/openlp/bug-1053654 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1053654 in OpenLP: Adding verses from multiple chapters fails https://bugs.launchpad.net/openlp/+bug/1053654 For more details, see:

[Openlp-core] [Merge] lp:~erik-lundin/openlp/bug-1053654 into lp:openlp

2012-09-20 Thread Erik Lundin
Erik Lundin has proposed merging lp:~erik-lundin/openlp/bug-1053654 into lp:openlp. Commit message: Fixed bug #1053654 'Adding verses from multiple chapters fails'. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1053654 in OpenLP: Adding verses from multiple chapters fails