[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-20 Thread noreply
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 Your team OpenLP Core

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-19 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-19 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 Your team OpenLP

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-17 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Status: Approved = Work in progress For more details, see: https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 Your team

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-17 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-804747 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Related bugs: Bug #804747 in OpenLP: Bible disappear after upgrade https://bugs.launchpad.net/openlp/+bug/804747 Bug #824129 in

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-17 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Commit Message changed to: - Fixed bug #804747 (Bible disappear after upgrade) - Fixed bug Bug #824129 (Bibles plugin does not always delete corrupted bibles from falied imports) - Removed not needed or

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-17 Thread Andreas Preikschat
Fixed a traceback on windows and fixed bug #824129 (there might still be cases where corrupted bibles were not removed, but this fixes this for windows). -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-17 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71841 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-16 Thread Raoul Snyman
Review: Approve At a glance looks fine to me. -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-16 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 Your team OpenLP

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-15 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-804747 into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #804747 in OpenLP: Bible disappear after upgrade https://bugs.launchpad.net/openlp/+bug/804747 For more details, see:

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-15 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Commit Message changed to: - Fixed bug #804747 (Bible disappear after upgrade) - Removed not needed or redundant variables. - Removed not needed code. - When upgrading bibles move the files to the temp

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-15 Thread Andreas Preikschat
Note: Especially testing on Windows is requested. -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-15 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71529 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-14 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-804747 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #804747 in OpenLP: Bible disappear after upgrade https://bugs.launchpad.net/openlp/+bug/804747 For more details, see:

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-14 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Commit Message changed to: - Fixed bug #804747 (Bible disappear after upgrade) - Removed not needed or redundant variables. - Removed not needed code. - When upgrading bibles move the files to the temp

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-14 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Description changed to: Hello, 1) Fixed bug #804747 (Bible disappear after upgrade) The fix is in line 303. we did not pass the file name, that means that we used the version name. If you do not pass the file

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-14 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Description changed to: Hello, 1) Fixed bug #804747 (Bible disappear after upgrade) The fix is in line 303. We did not pass the file name, that means that we used the version name. If you do not pass the file

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-14 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Description changed to: Hello, 1) Fixed bug #804747 (Bible disappear after upgrade) The fix is in line 303. We did not pass the file name, that means that we used the version name. If you do not pass the file

[Openlp-core] [Merge] lp:~googol/openlp/bug-804747 into lp:openlp

2011-08-14 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-804747 into lp:openlp has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71487 -- https://code.launchpad.net/~googol/openlp/bug-804747/+merge/71487 Your