The proposal to merge lp:~googol/openlp/clean-up into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146578
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146578
Your team OpenLP Core
Review: Approve
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146578
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
Review: Approve
Where's your functional test? :-P
But seriously, I would really like every merge proposal to be accompanied by a
test. This way we can hopefully eventually get most of OpenLP covered little
bit by little bit.
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146578
Y
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/32/
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146578
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpa
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/32/
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146578
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net
The proposal to merge lp:~googol/openlp/clean-up into lp:openlp has been
updated.
Description changed to:
Hello
- removed not needed imports; removed not needed script
- used += instead
- fixed short lines
- converted print statements
- reordered imports
For more details, see:
https://code.lau
I am going to fix the order as well.
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146566
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launch
Or too fast, depending on the point of view :D
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146566
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@li
Superfly: You are too slow :P
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146566
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Needs Fixing
187 from openlp.core.lib import Registrytranslate
whoops, I think that's supposed to be "Registry, translate"
Just for future reference (and I know you didn't specifically do it):
from openlp.core.lib import translate, Registry, Settings
Rather import classes first,
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146566
Hello
- removed not needed imports; removed not needed script
- used += in
The proposal to merge lp:~googol/openlp/clean-up into lp:openlp has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146565
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146565
Your team Op
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146565
Hello
- removed not needed imports; removed not needed script
- used += in
Review: Needs Fixing
A number of your import statements have extra spaces in them, or are missing
spaces after commas.
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146529
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mai
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146529
Hello
- removed not needed imports; removed not needed script
- used += inst
The proposal to merge lp:~googol/openlp/clean-up into lp:openlp has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146526
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146526
Your team Op
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/146526
Hello
- removed not needed imports; removed not needed script
- used += inst
Review: Needs Fixing
Things have moved on so needs a respin
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145963
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145963
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/29/
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145963
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net
Review: Needs Fixing
test_app is not part of the test framework and should be removed.
if you are cleaning up code then clean up the variable names as well when they
and not python names.
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145954
Your team OpenLP Core is subscribed to
Just merged trunk, thus didn't run a new build:
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/28/
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145954
Your team OpenLP Core is subscribed to branch lp:openlp.
__
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145954
Hello,
- removed not needed imports
- added missing
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/28/
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145952
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/145952
Hello,
- removed not needed imports
- added missing
Review: Needs Fixing
Needs a re-role after my merges
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/144608
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-
> http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-
> Pull_and_Run_Functional_Tests/14/console
I run the tests myself. But the test failes in trunk as well. So this isn't
causing it.
(And you weren't around yesterday so that I could ask you.)
--
https://code.launchpad.net/~googol/openlp/c
Review: Needs Fixing
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/14/console
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/144608
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailin
I check lp:~trb143/openlp/media: no conflicts :)
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/144608
Your team OpenLP Core is requested to review the proposed merge of
lp:~googol/openlp/clean-up into lp:openlp.
___
Mailing list: https:/
Andreas Preikschat has proposed merging lp:~googol/openlp/clean-up into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/clean-up/+merge/144608
Hello,
- removed not needed imports
- added missing lines
- use 'isinstance'
30 matches
Mail list logo
