Review: Needs Fixing
Sorry but this is the wrong way to improve the code.
Super Object methods have caused issues with tests due to the complexity of
creating the class. Here you are adding to the complexity not reducing it.
Also no tests.
--
https://code.launchpad.net/~googol/openlp/plugin
Andreas Preikschat has proposed merging lp:~googol/openlp/plugin-api into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/212295
Hello,
- moved things to Plugin class
--
https://code.launchpad.net/~googol/
I removed the weight change. Still passing the path in, because every plugin
needs the icon (hence the icon_path).
--
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/212295
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailin
Andreas Preikschat has proposed merging lp:~googol/openlp/plugin-api into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/212292
Hello,
- moved things to Plugin class
--
https://code.launchpad.net/~googol/
The proposal to merge lp:~googol/openlp/plugin-api into lp:openlp has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/212292
--
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/212292
Your t
> The api looks more complicated.
> You would read it and ask what -9 means. Not obvious
But the other changes are accepted?
--
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/184212
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Disapprove
The api looks more complicated.
You would read it and ask what -9 means. Not obvious
--
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/184212
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Andreas Preikschat has proposed merging lp:~googol/openlp/plugin-api into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/184212
Hello,
- moved things to Plugin class
--
https://code.launchpad.net/~go
Andreas Preikschat has proposed merging lp:~googol/openlp/plugin-api into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/184211
Hello,
- moved things to Plugin class
--
https://code.launchpad.net/~go
9 matches
Mail list logo