Is this ready to go now?
I can, assuming that we want soft breaks to be converted to v1a and the other
way around.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
Your team OpenLP Core is subscribed to branch lp:openlp.
___
From memory yes.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
Hello,
- modified song object - xml
Review: Approve
Looks fine but please wait till I have merged.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55483
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55403
Hello,
- modified song object - xml converter to consider
Review: Approve
Need to wait till I get in!
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/55403
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53899
Hello
- fixed adding Verse instead of v to the database.
- add
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53899
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53899
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53899
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53170
Hello
- removed adding a default verse order when
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53170
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53170
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53170
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/53170
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/50184
Hello!
- clear search edit line when starting the wizard again
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/50184
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/50184
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/50184
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/50184
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49128
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49222
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49222
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49222
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49222
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49274
Hello!
Just a small fix.
- do not add the entry attribute to
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49274
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49274
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Yes, I am. But I am not sure, if this dialog is what you wanted.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/48698
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Description changed to:
Hello!
- added a OpenLyrics exporter
- save OpenLyrics meta data to songs (service items and xml files)
- fixed a bug in OpenSong import
- fixed verse type when importing xml songs
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Description changed to:
Hello!
- added a OpenLyrics exporter
- save OpenLyrics meta data to songs (service items and xml files)
- fixed a bug in OpenSong import
- fixed verse type when importing xml songs
Review: Needs Fixing
Select All, DeSelect All is better that Check All, UnCheck All.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49128
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Approve
Select All, DeSelect All is better that Check All, UnCheck All.
I disagree. The user is not selecting anything, they are checking the
checkboxes. Those are standard buttons for checkbox interfaces.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/49128
Your
Are you going to resubmit this merge proposal at some stage?
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/48698
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
I reworked the dialog... But I'd like the service order print to be reviewed
first.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/48698
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Merged trunk and resolved conflict.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/48518
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
The export wizard is ugly (you simply copied OpenLP 1, so I don't blame you).
Here's a better solution:
http://img88.imageshack.us/img88/6154/openlpexportselect.png
http://img12.imageshack.us/img12/6241/openlpexportselected.png
--
I'll resubmit, when meths' changes are merged.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/47912
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Approved
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/47912
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
'openlp_stop_wizard - does not say which wizard. stop_song_export would be
better
blank lines in method retranslateUi
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/47674
Your team OpenLP Core is subscribed to branch lp:openlp.
'openlp_stop_wizard - does not say which wizard. stop_song_export would be
better
But thats the signal defined in the eventreceiver and it's emmitted from the
OpenLPWizard class (ui/wizard.py:121) anyway.
blank lines in method retranslateUi
I'll remove them.
--
Review: Needs Fixing
Who left a print statement in then!
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46874
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Who left a print statement in then!
The print statements belong to the print_song() method.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46874
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
Jon Tibble (meths)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
Hello!
- The reindex tool removes the language
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46817
Hello!
- The reindex tool removes the language attribute from
Review: Needs Fixing
Resubmit after new commits.
Remove line 21/22 rather than editing.
The for file_path in self.import_source in openlyricsimport means the
importer can accept more than one file so don't return False if an XML parse
fails, log it and move on to the next file.
--
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
Jon Tibble (meths)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46874
Hello!
- The reindex tool removes the language attribute from the
You're using both 0 and None for incorrect editId values [...]
No, I return None, as superfly suggested here:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45882
Your team OpenLP Core is subscribed to
mediaitem.py:426
editId = 0
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45882
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
mediaitem.py:426
editId = 0
Yes, your right. I did not catch that one.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45882
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Jon Tibble (meths)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46010
Hello!
Clean up from last merge:
- removed not
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46010
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Approved
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46010
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46010
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46010
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45882
Hello!
Clean up from last merge:
- removed not needed
Review: Approve
Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45882
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
You're using both 0 and None for incorrect editId values if I'm reading this
correctly so please change line 9 from
if editId is not None:
to
if editId:
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45882
Your team OpenLP Core is subscribed to branch
Review: Approve
Approved.
We does only support one song book, so take the first one should be We only
support one song book, so take the first one
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
You might want to return None instead of 0 if there's no XML, and do if
song_id is None, but that's just semantics.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
Review: Needs Fixing
LyricsXML code is commented out which should be deleted or used. Has this been
moved?
Service Song imports matches Above All Powers with 1Above All Powers1 is
this correct as it should be a different song.
--
Service Song imports matches Above All Powers with 1Above All Powers1 is
this correct as it should be a different song.
I did not change the algorithm which detects that. However, I added the
re.compile code from the re-index tool, to make sure, that the (search) titles
are formatted in the
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646
- added OpenLyrics importer
- continued to implement OpenLyrics
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45619
- added OpenLyrics importer
- continued to implement OpenLyrics
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45620
- added OpenLyrics importer
- continued to implement OpenLyrics
65 matches
Mail list logo
