Andreas Preikschat has proposed merging lp:~googol-hush/openlp/images into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490
Update the little preview fame, when replacing the live background. In trunk
Review: Approve
Approved.
Nice Fix
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
Approved
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/images into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46416
Update the little preview fame, when replacing the live background. In
Review: Needs Fixing
The idea is correct but I think this should be done in core not in the plugins
so the send events should be inside the controllers.
That way we have the functions managed better if new plugins ever arrive.
--
Tim:
I have not much to do with this code, but as far as I see this, there is no
central place to put this code. As you see in lines 21/34/70/83 the process of
replacing/resetting the live background depends on the type (media/image) -
four different methods. Well, I can add the code to methods
The code should be in MainDisplay so it is central for all users incase someone
wants to reuse the method or someone cleans up the plugins incorrectly.
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/46416
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
Approved
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~googol-hush/openlp/images into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007
Your team
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/images into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007
Hello!
- fixed adding/appending more images to the Service Manager
-
The proposal to merge lp:~googol-hush/openlp/images into lp:openlp has been
updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/images/+merge/44985
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/44985
Your
Review: Approve
Nice fix
--
https://code.launchpad.net/~googol-hush/openlp/images/+merge/44984
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
13 matches
Mail list logo