[Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-17 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/images into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490 Update the little preview fame, when replacing the live background. In trunk

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-17 Thread Tim Bentley
Review: Approve Approved. Nice Fix -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-17 Thread Jonathan Corwin
Review: Approve Approved -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-17 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/46490 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/images into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol-hush/openlp/images/+merge/46416 Update the little preview fame, when replacing the live background. In

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-16 Thread Tim Bentley
Review: Needs Fixing The idea is correct but I think this should be done in core not in the plugins so the send events should be inside the controllers. That way we have the functions managed better if new plugins ever arrive. --

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-16 Thread Andreas Preikschat
Tim: I have not much to do with this code, but as far as I see this, there is no central place to put this code. As you see in lines 21/34/70/83 the process of replacing/resetting the live background depends on the type (media/image) - four different methods. Well, I can add the code to methods

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-16 Thread Tim Bentley
The code should be in MainDisplay so it is central for all users incase someone wants to reuse the method or someone cleans up the plugins incorrectly. -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/46416 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-03 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-03 Thread noreply
The proposal to merge lp:~googol-hush/openlp/images into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007 -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007 Your team

[Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-02 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/images into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol-hush/openlp/images/+merge/45007 Hello! - fixed adding/appending more images to the Service Manager -

[Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-01 Thread Andreas Preikschat
The proposal to merge lp:~googol-hush/openlp/images into lp:openlp has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~googol-hush/openlp/images/+merge/44985 -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/44985 Your

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/images into lp:openlp

2011-01-01 Thread Tim Bentley
Review: Approve Nice fix -- https://code.launchpad.net/~googol-hush/openlp/images/+merge/44984 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net