Meinert: any change you pick up with this?
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
I suggested the use of Qt comparision as well, but as it was reported to have a
poor performance, I delayed this until I had time to test the performance under
Windows.
For long time I did not take the time, to setup Windows and make a test. So
please test the performance on Windows for big
I think this merge can be closed since there is a new pending request to fix
related bug.
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Where was this left out of interest? Who is waiting on who?
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Information
Meinert, I'd just like us to do a little more playing around with this before
we merge it. In particular I'm thinking of testing out the Search as you type
speed, and documenting on the wiki how to include ICU in the Windows build.
--
The proposal to merge lp:~m2j/openlp/bug-687638 into lp:openlp has been updated.
Status: Approved = Work in progress
For more details, see:
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core
Review: Needs Information
A question, did you compare the performance? I am not sure, but isn't the
function you specify called dozens times?
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
I haven't checked it yet, as I have no Windows machine with Python arround ATM.
The only position where we are sorting big lists is in the songs media manager
(after editing/importing/deleting a song). Therefore we should have some
realtime performance for up to 2000 strings.
--
The only position where we are sorting big lists is in the songs media manager
(after editing/importing/deleting a song).
Do not forget the Search as you type feature!
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
The proposal to merge lp:~m2j/openlp/bug-687638 into lp:openlp has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
While looking for other i18n things (and figuring out, that Qt just introduced
nice methods like QLocale::createSeparatedList()), I stumbled over the fact,
that the performance of Qts implementation of collation might be fine as well.
Sorting 1500 strings with Python takes about 20ms so that
Maybe somebody with windows should test this?
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Approve
This looks OK to me.
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Some more informations:
ICU binaries for Windows have a size of arround 9MB as they contain a lot of
data.
I haven't figured out any other way to collide international strings on Windows
with comparable performance.
Some information about colliding and Qt can be found on this blog post:
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-687638 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
I've splitted a previous merge request. This one contains only ICU integration:
Bug
16 matches
Mail list logo
