The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
Your team OpenLP Core is subscribed
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
Your team OpenLP Core is subsc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Meinert Jordan has proposed merging lp:~m2j/openlp/cleanups into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232
pythonifying code:
- replace has_key() by key in dict
- remove len() method from seq
But the rest is okay.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104021
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Review: Needs Fixing
Can you please revert your changes in mediacontroller.py, because I already
have a proposal which changes the same things:
https://code.launchpad.net/~googol/openlp/bug-966086/+merge/103987
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104021
Your team OpenLP Co
Meinert Jordan has proposed merging lp:~m2j/openlp/cleanups into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104021
pythonifying code:
- replace has_key() by key in dict
- remove len() method from seque
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104019
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104019
Your team OpenLP Core
Meinert Jordan has proposed merging lp:~m2j/openlp/cleanups into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104019
pythonifying code:
- replace has_key() by key in dict
- remove len() method from seque
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
Your team OpenLP Core is subscribed
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
Your team OpenLP Core is subsc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Meinert Jordan has proposed merging lp:~m2j/openlp/cleanups into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
fix: wrong method name
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100891
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100663
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100663
Your team OpenLP Core is subscribed
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100663
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100663
Your team OpenLP Core is subsc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100663
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100663
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
840: a space too many, as mentioned on IRC.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100657
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100657
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
I've just tried to merge against HEAD. there are no conflicts.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : o
Review: Resubmit
Changing this to a "Please Resubmit" to just remind us all that the other
proposals should be merged before this one, and then trunk HEAD should be
merged in, and the proposal resubmitted.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501
Your team OpenLP Core is
Review: Approve
Make sure you merge HEAD from trunk after all the other fixes go in.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~open
Review: Approve
Approved
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
Review: Needs Fixing
248 need a space increate_push_button
2029 OnItemTriggered should be OnItemActivated
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100350
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https
As I said: No features added, no functional change. Using the wrong button
signal can be rated as bug, but I don't want to argue about it, as there is no
point to argue about the categorisation.
For usual releases such changes are permitted until the very end of the merge
window.
--
https://co
Review: Needs Fixing
Marking as Needs fixing as I have a challenge here.
We have moved from a Beta to RC phase and new features should not be added.
This is a big change with a lot of churn. Is this the right time?
If there are bugs being fixed create one and tag it.
Will not be on IRC till t
[quote]The path seperator in zip files is always a slash (/):
http://www.pkware.com/documents/casestudies/APPNOTE.TXT[/quote]
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is subscribed to branch lp:openlp.
___
M
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is subscribed to
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is subscri
Review: Approve
Approved and Jonathan has confirmed Windows is not impacted which was my worry.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad
Tim, do you mean these type of lines?
619 -filename =
unicode(QtCore.QDir.toNativeSeparators(filename))
620 +filename = unicode(filename).replace(u'/', os.path.sep)
I don't think the functionality has changed, just the method used for
consistency with other code.
Review: Needs Information
removing the qt native separators are using "/" is that not going to cause
windows users problems.?
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
Approve.
Sorry I didn't understand your Needs Fixing on Raoul's merge at the time, I
thought you were objecting to it causing conflicts in your branch, not that the
logic was back to front!
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is
lines 2021-2022:
https://code.launchpad.net/~raoul-snyman/openlp/bug-845692/+merge/95794
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225
Your team OpenLP Core is requested to review the proposed merge of
lp:~m2j/openlp/cleanups into lp:openlp.
___
bzr update
bzr commit 'Head'
bzr push
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/95879
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
Can you tell me, how I have to do this?
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/95879
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchp
Review: Needs Fixing
Please rebase against head as you are removing recent fixes.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/95879
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-c
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Commit Message changed to:
Unify all QAction creation methods.
derive OpenLPToolbar().actions keys from object names.
use Python methods instead of Qt for file path manipulations.
Bug #943919: Shortcuts for "Move to Pr
I expected Raouls changes will be as good as merged (they were already approved
and I discovered his bug at the end of merging).
I'm about to leave for some days and I don't know yet, if I can care about
resolving conflicts. Therefore I decided to merge with Raoul instead of waiting
for a update
Review: Needs Fixing
Please revert that. Raoul's branch is missing features, your branch is
cleanups, they have nothing to do with each other and should remain separate.
Lets get one of them approved and merged, then we can resolve conflicts in the
second one.
--
https://code.launchpad.net/~m
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Commit Message changed to:
Unify all QAction creation methods.
derive OpenLPToolbar().actions keys from object names.
use Python methods instead of Qt for file path manipulations.
Bug #943919: Shortcuts for "Move to Pr
I've merged
https://code.launchpad.net/~raoul-snyman/openlp/bug-845692/+merge/95794 into
this branch (because I did not have the time to wait until it enters trunk).
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/95796
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/95796
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : h
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Commit Message changed to:
Unify all QAction creation methods.
derive OpenLPToolbar().actions keys from object names.
use Python methods instead of Qt for file path manipulations.
Bug #943919: Shortcuts for "Move to Pr
Review: Needs Fixing
m2j: In cleanups, I asked it to use "P" for previous item, and it
allowed me to do it even though it is already the shortcut for pre-chorus
gushie: I will look into that
m2j: I guess there is some form of context? Since other items in the
Live group appear to warn me OK
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Commit Message changed to:
Unify all QAction creation methods.
derive OpenLPToolbar().actions keys from object names.
use Python methods instead of Qt for file path manipulations.
Bug #943919: Shortcuts for "Move to Pr
Sorry, I just realized, that I accidently pushed some revision up before making
a uncommit and recommit for final changes. So I did not recogniced, that the
next push was not working.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/95733
Your team OpenLP Core is subscribed to branch lp
Review: Needs Fixing
First the minor:
934,945: You have an extra space after the first =
Secondly the more serious, it wouldn't start for me:
Traceback (most recent call last):
File "openlp.pyw", line 35, in
from openlp.core import main
File "C:\Users\Jonathan\Documents\projects\openlp\
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Commit Message changed to:
Unify all QAction creation methods.
derive OpenLPToolbar().actions keys from object names.
use Python methods instead of Qt for file path manipulations.
Bug #943919: Shortcuts for "Move to Pr
I've added a category for two actions, as
https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/95676 interferes
completely with my code.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94927
Your team OpenLP Core is subscribed to branch lp:openlp.
_
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Commit Message changed to:
Unify all QAction creation methods.
derive OpenLPToolbar().actions keys from object names.
use Python methods instead of Qt for file path manipulations.
For more details, see:
https://code.l
So I unified all QAction creation methods. So we end up by saving 200 lines of
code.
Furthermore I'm using the objectNames for keys in OpenLPToolbar.actions as
translated strings might break OpenLP by translators.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94927
Your team OpenLP C
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94927
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94927
Your team OpenLP Core is
I replaced all action creation methods except of context_menu_action (which is
still to be done).
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94927
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchp
I missed some u''s. Will change this.
--
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94829
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad
Review: Needs Fixing
I would suggest using **kwargs instead of a whole bunch of named parameters
which might only get longer. It makes the method forward and backward
compatible.
Eventually it would be great to replace all the action creation methods with
the single kwarg'd version, but we can
Meinert Jordan has proposed merging lp:~m2j/openlp/cleanups into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94692
This are some cleanups.
There were five methods to create a action in OpenLP, so I thou
59 matches
Mail list logo
