[Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2014-03-22 Thread Andreas Preikschat
The proposal to merge lp:~marmyshev/openlp/bug_1117098 into lp:openlp has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192797 -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192797 Yo

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2014-03-22 Thread Andreas Preikschat
Review: Resubmit -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192797 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2014-03-22 Thread Andreas Preikschat
Hello, If you are going to work on this, please execute these commands: bzr tag "2.2.2" --delete bzr tag "help" --delete But for now, I am setting this to rejected -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192797 Your team OpenLP Core is subscribed to branch lp:openl

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-11-10 Thread Raoul Snyman
Review: Needs Fixing There are still 3 tests in your branch which are failing. http://ci.openlp.org/view/Branch/job/Branch-02-Functional-Tests/9/console -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192797 Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-10-26 Thread Dmitriy Marmyshev
Dmitriy Marmyshev has proposed merging lp:~marmyshev/openlp/bug_1117098 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) Related bugs: Bug #1117098 in OpenLP: "Transparen theme is white on Mac OSX" https://bugs.launchpad.net/

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-10-25 Thread Raoul Snyman
Review: Needs Fixing Please merge trunk, and fix your test to match the way the others import mock. http://ci.openlp.org/view/Branch/job/Branch-02-Functional-Tests/7/console -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192582 Your team OpenLP Core is subscribed to branch lp

[Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-10-24 Thread Dmitriy Marmyshev
Dmitriy Marmyshev has proposed merging lp:~marmyshev/openlp/bug_1117098 into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) Related bugs: Bug #1117098 in OpenLP: "Transparen theme is white on Mac OSX" https://bugs.launchpad.net/

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-10-24 Thread Dmitriy Marmyshev
haha :)) fast typing. On Thu, Oct 24, 2013 at 11:57 PM, Tim Bentley wrote: > Review: Needs Fixing > > main_dispaly > -- > https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192565 > You are the owner of lp:~marmyshev/openlp/bug_1117098. > -- https://code.launchpad.net/~marmy

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-10-24 Thread Tim Bentley
Review: Needs Fixing main_dispaly -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/192565 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lis

[Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-10-24 Thread Dmitriy Marmyshev
Dmitriy Marmyshev has proposed merging lp:~marmyshev/openlp/bug_1117098 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) Related bugs: Bug #1117098 in OpenLP: "Transparen theme is white on Mac OSX" https://bugs.launchpad.net/openlp/+bug/1117098 Fo

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-18 Thread Jonathan Corwin
This now works fine on Windows -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launch

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-18 Thread Phill
Dmitriy, http://wiki.openlp.org/Development:Unit_Tests should be of some help. A good example to follow would be http://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/tests/functional/openlp_plugins/songs/test_foilpresenterimport.py The encoding_declaration_removal_test method is pr

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-17 Thread Dmitriy Marmyshev
Raoul, can you help me wiht writing test for this? Because I dont know how to test it. -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpa

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-17 Thread Jonathan Corwin
Review: Needs Fixing This causes a 1 pixel white border to appear around the transparent display screen on Windows. -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-17 Thread Raoul Snyman
Review: Needs Fixing sorry, you need to write a test -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : o

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-17 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsub

[Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-17 Thread Dmitriy Marmyshev
Dmitriy Marmyshev has proposed merging lp:~marmyshev/openlp/bug_1117098 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1117098 in OpenLP: "Transparen theme is white on Mac OSX" https://bugs.launchpad.net/openlp/+bug/1117098 For more details, see: https://co