Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173403
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~phill-ridout/openlp/1114457 into lp:openlp has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173403
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173403
Your
The proposal to merge lp:~phill-ridout/openlp/1114457 into lp:openlp has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173403
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173403
Your team
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173403
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Sorry, didn't even see your comment! I'll get to it!
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173315
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer
Review: Approve
Please run bzr tag --delete 2.2.2 on your branch and then push it up again.
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/173315
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Needs Fixing
==
ERROR: Test the :mod:`doImport` module opens the correct files
--
Traceback (most recent call last):
File
Review: Needs Fixing
180 +TEST_PATH = os.path.abspath(os.path.join(os.path.dirname(__file__),
u'../../../resources/easyworshipsongs'))
You need to use os.path.join with each part of that path separately:
TEST_PATH = os.path.abspath(os.path.join(os.path.dirname(__file__), u'..',
u'..',
Review: Needs Fixing
41 - if not os.path.isfile(self.import_source):
42 - return
43 - if not os.path.isfile(import_source_mb):
44 + if not (os.path.isfile(self.import_source) or
os.path.isfile(import_source_mb))
Should be:
if not os.path.isfile(self.import_source) or
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Tim Bentley (trb143)
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Andreas Preikschat (googol)
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer
Will you continue to work on this?
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/159986
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
Lines 8-17
Tests also fail
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/87/console
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/159986
Your team OpenLP Core is subscribed to branch lp:openlp.
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer progress bar is out
Review: Needs Fixing
self.type = field_type
Please rename the attribute as well.
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/159502
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Needs Fixing
125 +TEST_PATH = os.path.abspath(os.path.join(os.path.dirname(__file__),
u'../../../resources/easyworshipsongs'))
126 +SONG_TEST_DATA = [{u'title': u'Amazing Grace',
Why are these constants below some other classes?
--
Because I wanted to keep the constants together.
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/159202
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer progress bar is out
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer progress bar is out
Any progress on this?
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/152367
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Any progress on this?
Oh sorry, your proposal isn't that old. (I am just checking the old
proposals.)
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/152367
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Needs Fixing
You have a conflict:
Text conflict in openlp/plugins/songs/lib/ewimport.py
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/152367
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Andreas Preikschat has proposed merging lp:~phill-ridout/openlp/1114457 into
lp:openlp with lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Andreas Preikschat (googol)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer progress bar is out
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/152367
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Looks OK to me, but I don't have an EW database to test it on.
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/152367
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
@Raoul: dropbox
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/152367
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Resubmit
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/151080
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Don't forget to resubmit your merge proposal to include the newer revisions.
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/151080
Your team OpenLP Core is requested to review the proposed merge of
lp:~phill-ridout/openlp/1114457 into lp:openlp.
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1114457 in OpenLP: Easy Worship importer progress bar is out
31 matches
Mail list logo
