This is old code and the application has changed since this was started,
If it is still an issue please resubmit.
--
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
Your team OpenLP Core is subscribed to branch lp:openlp.
__
The proposal to merge lp:~rafaellerm/openlp/media_import_fix into lp:openlp has
been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
How far did you come?
--
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad
Yeah that would be a good test.
Don't hesitate to ask if you need help.
--
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~ope
> Rafael, are you going to continue work on this?
> The test is still missing.
Yes, but I don't have a good idea of what I could test, so maybe this will take
some time, since I am currently unable to put much effort in. Would testing the
format strings (which were wrong) be enough?
Also I woul
Review: Needs Fixing
Rafael, are you going to continue work on this?
The test is still missing.
--
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: h
> This does not need a bug as is new functionality and bug fix.
>
> Need to understand why lines 33 and 46.
>
> Also it would be nice to get a test written. It does not need to reflect this
> change but if every one writes a test then the test coverage gets better.
(I think I did not reply this
In line 33, 'item' is a string (I did not alter this). As a string is an
iterable, calling append would cause 'self.video_extensions_list' to be a list
os characters, not a list of strings. E.g. it would be ['V','i','d','e','o','
','f',...] instead of ["Video files ..."]
In line 46, an action w
Review: Needs Fixing
This does not need a bug as is new functionality and bug fix.
Need to understand why lines 33 and 46.
Also it would be nice to get a test written. It does not need to reflect this
change but if every one writes a test then the test coverage gets better.
--
https://code.la
Rafael Lerm has proposed merging lp:~rafaellerm/openlp/media_import_fix into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
This fixes the adding of images and media to the media manag
10 matches
Mail list logo
