Review: Needs Fixing
Line 1669: I think it gets the text of the current song, rather than slide? But
may be wrong...
Remove commented code on 1734, 1743, 1744, 2062, 2063
Indent too big on line 1765
--
https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53605
Your team OpenLP Core is
Review: Approve
From my point of view looks fine.
I don't read JS !
--
https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53605
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
I'm going to approve as it is much better than previously. Looks great.
However one issue that may need looking at is that on my android browser, for
some reason when I go into the slides or service I then need to force a reload
through the browser to pick up changes. Once I've
The proposal to merge lp:~raoul-snyman/openlp/json into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618
--
https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618
Your team OpenLP
5 matches
Mail list logo