[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-23 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144179 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144179 Your team Ope

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-21 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144179 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-21 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144179 Fix a test that used a more updated version of Mock that what the Jenkins ser

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-21 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144064 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144064 Your team Ope

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-20 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144064 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-20 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144064 Get Tim's two tests running. -- https://code.launchpad.net/~raoul-snyman/open

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-20 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144036 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144036 Your team Ope

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-20 Thread Tim Bentley
Review: Approve Looks good and should solve some of my problems. Well it gives me clues! -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144036 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpa

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-20 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/144036 Written some more tests. I have written some more tests, bringing our total n

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-15 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251 Your team OpenLP

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-15 Thread Andreas Preikschat
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251 Your team O

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-15 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-08 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-07 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1094346 in OpenLP: "SIP version 2 rewrite broke automated test" https://bugs.launchpad.net/openlp/+bug/1094346 For more details, see: https://code.

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-07 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142106 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142106 Your team Ope

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-07 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142106 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2013-01-07 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142106 Fix failing get_data_path_with_custom_location_test() Fix the test that fails

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-08 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Your team OpenLP

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-08 Thread Tim Bentley
The proposal to merge lp:~raoul-snyman/openlp/tests into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Your team O

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-08 Thread Jonathan Corwin
Review: Approve OK, approve since it'll be good to get some examples in place. It would be good to get them standardized before it gets forgotten though! -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-07 Thread Tim Bentley
Review: Approve Approved but standards need to be sorted. -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-07 Thread Raoul Snyman
Likely. Tim just asked me to merge, so I did. It is a little easier to read the flow of the tests with the blank lines. -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-07 Thread Jonathan Corwin
Review: Needs Information Is there going to be a standard over whether or not there are blank lines after the GIVEN/WHEN/THEN's? There seems to be a mix... -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-07 Thread Tim Bentley
Review: Approve Looks Ok but time will tell! -- https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138829 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-07 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138831 Some initial unit tests. -- https://code.launchpad.net/~raoul-snyman/openlp/t

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/tests into lp:openlp

2012-12-07 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/138829 Some initial unit tests. -- https://code.launchpad.net/~raoul-snyman/openlp/t