The proposal to merge lp:~springermac/openlp/fix-ups into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Your team Open
The proposal to merge lp:~springermac/openlp/fix-ups into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Your tea
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
Yes we use the other roles to specify which menu item is used.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Your team OpenLP Core is requested to review the proposed merge of
lp:~springermac/openlp/fix-ups into lp:openlp.
___
Do we set the other roles? I'm thinking of these ones in particular:
QAction::PreferencesRole
QAction::AboutRole
QAction::QuitRole
They might also help?
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Your team OpenLP Core is requested to review the proposed merge o
Jonathan Springer has proposed merging lp:~springermac/openlp/fix-ups into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/218827
Change how we define which menu items are included in the main menu on
The proposal to merge lp:~springermac/openlp/fix-ups into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
Your team Open
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
The proposal to merge lp:~springermac/openlp/fix-ups into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
Your tea
Review: Approve
I prefer the following import order:
1. Python library imports
2. Third party imports
3. OpenLP code imports
4. OpenLP test imports
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
Your team OpenLP Core is subscribed to branch lp:openlp.
_
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/335/
[SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/292/
[SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/240/
[SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/202/
[SUCCESS] http://ci.openlp.org/job/Branch-05a-C
Jonathan Springer has proposed merging lp:~springermac/openlp/fix-ups into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215942
Fixes first time wizard to use url and paths in web config file
Fixes
The proposal to merge lp:~springermac/openlp/fix-ups into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
Your team Open
The proposal to merge lp:~springermac/openlp/fix-ups into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
Your tea
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
Review: Approve
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
Jonathan Springer has proposed merging lp:~springermac/openlp/fix-ups into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
matysek (mzibricky)
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/215324
Remove orphaned and unu
Review: Approve
Looks good to me too.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214838
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.
Review: Approve
Looks good and nice test
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214838
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lis
Jonathan Springer has proposed merging lp:~springermac/openlp/fix-ups into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
matysek (mzibricky)
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214838
Remove orphaned and unu
I'm writing one for the new function just trying to figure out the testing
framework.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.n
Review: Needs Fixing
Needs tests. How about one for the new function.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
[SUCCESS] http://ci.openlp.org/job/Branch-01-Pull/247/
[SUCCESS] http://ci.openlp.org/job/Branch-02-Functional-Tests/208/
[SUCCESS] http://ci.openlp.org/job/Branch-03-Interface-Tests/157/
[SUCCESS] http://ci.openlp.org/job/Branch-04-Windows_Tests/118/
[FAILURE] http://ci.openlp.org/job/Branch-05-Co
Review: Approve
I think I'm fine.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.laun
> Am I supposed to test this anyhow?
No. I removed the code that I wanted you to look at.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchp
Am I supposed to test this anyhow?
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.laun
Jonathan Springer has proposed merging lp:~springermac/openlp/fix-ups into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
matysek (mzibricky)
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Remove orphaned and unused registry execute, a
Still working on a test.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214464
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The unfortunate thing is that in qt5 all menu items that contain the names
mentioned in the comment are stripped from the menu and don't show up anywhere
except for the first menu item which is used as the preferences menu item.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/21
The rest is fine, I just disagree with the menu items
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214015
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : ope
Review: Disapprove
I'll be the first to admit that I don't (yet) own a Mac, but I disagree with
renaming the actions. I know that most intelligent people can infer that these
are settings, but sadly a lot of people are not going to.
In addition to that, I looked at various HIGs when starting Op
Jonathan Springer has proposed merging lp:~springermac/openlp/fix-ups into
lp:openlp.
Requested reviews:
matysek (mzibricky)
For more details, see:
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214015
Remove unnecessary platform specific code, remove orphaned and unused regist
I will add a test later just wanted comments on changes first.
--
https://code.launchpad.net/~springermac/openlp/fix-ups/+merge/214015
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
34 matches
Mail list logo
