The proposal to merge lp:~staffj01/openlp/slideadvance into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
Your team
The proposal to merge lp:~staffj01/openlp/slideadvance into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
Your
Review: Approve
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
Review: Approve
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/91652
Changing the "Wrap Slide" option into a th
Jonathan, I have one small, but big, request.
That group box looks really squashed on the General page, and the Advanced page
has very few settings. Could you possibly move the "default image" and "mouse
cursor" under the "UI settings" and then put the "service item slide limits"
either above o
Review: Approve
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90623
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90623
Changing the "Wrap Slide" option into a th
Review: Needs Fixing
Works fine
361 u'last slide' u is missing
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90571
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Looks good, but I want to play with it before I approve it.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90571
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90571
Changing the "Wrap Slide" option into a th
Review: Needs Fixing
Yup, as Tim said, putting the SlideAdvance enumeration class in serviceitem.py
is probably not best place for it. Either put it in slidecontroller.py or in
lib/__init__.py
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90098
Your team OpenLP Core is subs
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90098
Changing the "Wrap Slide" option into a th
Review: Needs Fixing
Nice one but why is the Enumeration in ServiceItem It should be in
slidecontroller.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90064
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing lis
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90064
Changing the "Wrap Slide" option into a th
Review: Needs Fixing
u'previous last slide' and his mates should be moved to a enumeration class.
The values do not matter as such but it will become more obvious what is going
on.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89645
Your team OpenLP Core is subscribed to b
A third option is added to the queue in the following lines.
369 self.keypress_queue.append(u'previous last slide')
370 self._process_queue()
Would you prefer me to try and modify the servicePrevious routine to contain
both options there depending on a supplied argument?
--
https://code.launchp
Review: Needs Fixing
320 elif keypressCommand == u'previous last slide' cannot be right only
previous or last are written to the queue.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89645
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89645
Changing the "Wrap Slide" option into a th
In regards to 320, I added a third option down in 370-371 to get it to jump to
the last slide of the previous set item if the up arrow was pressed, but still
leaving the left/right arrow functionality intact.
It also looks like I forgot to remove the commented out line 369!
--
https://code.laun
Yes, the slide list on the android app still showed the same slides, while
OpenLP had jumped to the next service item.
I'll test again with 0.3 when it is released.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
261 need a u before the string
320 test must be incorrect as stack has "provious" and "next only added.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
Your team OpenLP Core is subscribed to branch lp:openlp.
_
0.3 version of Android will be release 23/1 - I have tested head and your code
against the 0l.3 version and get the same behaviours if set to "next".
What do you mean by slide list does not get updated? On the android app?
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
I just tested the changes with the android app and discovered a problem with
the "Next" slide advance setting. When you are in the 'slide' view of the
android app clicking the previous/next buttons work as expected, but when using
the "Next" slide advance setting, the slide list doesn't update w
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
Changing the "Wrap Slide" option into a th
Review: Needs Fixing
Need to update Receiver() class to document the signal
Looks good apart from that.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89006
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89006
Changing the "Wrap Slide" option into a th
Have a look at this event and follow it through it would give you a different
idea on what you could do.
slidecontroller_live_spin_delay
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/88655
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Needs Information
In Slide Controller would it be better to move slide_advance to the display /
config initialision code and reference it by self.slide_advance. That way to
config does not need to be referenced each slide refresh. The value will not
change very often.
--
https://code
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/88655
Changing the "Wrap Slide" option into a th
Review: Needs Fixing
262 + if QtCore.QSettings().value(
263 + self.parent().generalSettingsSection + u'/slide advance',
264 + QtCore.QVariant(SlideAdvance.End)).toInt()[0] \
265 + == SlideAdvance.Wrap:
266 row = self.previewListWidget.rowCount() - 1
267 + elif QtCore.QSettings().
Review: Approve
Works Ok - nice one
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/88606
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.l
Review: Needs Fixing
onSlideSelectedNext signature has changed but uses of it have not been tested.
Try a timer !
Mainwindow code does not need local variable
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/88601
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Needs Fixing
This looks like a good start, but here are couple of things that need to
be fixed up:
1. GUI object names:
Currently your GUI object names use PascalCase, but they should use
camelCase.
self.SlideGroupBox => self.slideGroupBox
2. Indentation is incorrect:
In the
34 matches
Mail list logo
