Re: [Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-23 Thread Tim Bentley
Yes miss read ScreenList! Code works and does make things cleaner. -- https://code.launchpad.net/~trb143/openlp/bug-1097898/+merge/144400 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/bug-1097898 into lp:openlp.

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-22 Thread Raoul Snyman
Your Registry.create() method is wrong. If you're supposed to use it to create the instance of the Registry, you are not doing that. Additionally, it is a class method, so the first parameter is a class, not an object. Lastly, your return value ("registry") is None because the create method does

[Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-22 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bug-1097898 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1097898 in OpenLP: "Exiting liveview with Alt-F4 causes OpenLP to become unstable" https://bugs.launchpad.net/openlp/+bug/1097898 For more details,

[Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-22 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bug-1097898 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1097898 in OpenLP: "Exiting liveview with Alt-F4 causes OpenLP to become unstable" https://bugs.launchpad.net/openlp/+bug/1097898 For more details,

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-15 Thread Raoul Snyman
Review: Needs Information Will this only happen when the person is using a single-display setup, or will this happen all the time? If this happens all the time, I don't want this change. I want the slide controller to always have focus when I'm using it in dual-screen mode. -- https://code.lau

[Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-15 Thread noreply
The proposal to merge lp:~trb143/openlp/bug-1097898 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/bug-1097898/+merge/142955 -- https://code.launchpad.net/~trb143/openlp/bug-1097898/+merge/142955 Your team Ope

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-15 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bug-1097898/+merge/142955 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

[Openlp-core] [Merge] lp:~trb143/openlp/bug-1097898 into lp:openlp

2013-01-11 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bug-1097898 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1097898 in OpenLP: "Exiting liveview with Alt-F4 causes OpenLP to become unstable" https://bugs.launchpad.net/openlp/+bug/1097898 For more details,