Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #657860 in OpenLP: At the end of a video, the last frame stays on
screen.
https://bugs.launchpad.net/openlp/+bug/657860
Bug #693150 in OpenLP: Custom
Review: Needs Information
What is 200 in terms of setTickInterval? Can you maybe just put a comment
in that explains what the unit is for that number? i.e.
# Need the timer to trigger
if self.serviceItem.start_time != 0:
# Set the tick interval to 200ms
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #657860 in OpenLP: At the end of a video, the last frame stays on
screen.
https://bugs.launchpad.net/openlp/+bug/657860
Bug #693150 in OpenLP: Custom
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53213
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53213
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53213
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53213
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53213
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #693150 in OpenLP: Custom Slide Display footer option
https://bugs.launchpad.net/openlp/+bug/693150
Bug #693202 in OpenLP: delete theme
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #693150 in OpenLP: Custom Slide Display footer option
https://bugs.launchpad.net/openlp/+bug/693150
Bug #693202 in OpenLP: delete theme
Review: Needs Fixing
Conflicts.
Plus should be Plugins not Plugings on lines 62/70
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53135
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Related bugs:
Bug #693150 in OpenLP: Custom Slide Display footer option
https://bugs.launchpad.net/openlp/+bug/693150
Bug #693202 in OpenLP: delete theme
Review: Approve
Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53138
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53138
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53138
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53138
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #693150 in OpenLP: Custom Slide Display footer option
https://bugs.launchpad.net/openlp/+bug/693150
Bug #693202 in OpenLP: delete theme
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53068
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
Report Creation should rather say, Output Path Not Selected
No output path has been selected for the report. should say, You have not
set a valid output location for your song usage report. Please select an
existing path on your computer.
--
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Andreas Preikschat (googol-hush)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #693150 in OpenLP: Custom Slide Display footer option
https://bugs.launchpad.net/openlp/+bug/693150
Bug #693202 in
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53071
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53071
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53071
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/53071
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52317
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52317
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52317
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52317
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
#712252
Review: Approve
There's a lot of stripping going on here, are you sure it's kosher? :-P
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52330
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52330
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52330
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52330
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52229
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52229
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52229
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
#728551
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
#728551
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52100
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52100
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/52100
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51446
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
Looks good
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51446
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb143/openlp/bugs into lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51406
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51406
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51406
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
#725887
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51335
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/51335
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50636
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50636
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50636
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50653
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50653
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50653
Your team OpenLP Core is subscribed
Review: Approve
The correct fix for README shouldn't add line 11, it should just remove line 9
but nevermind.
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50499
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50499
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50499
Your team OpenLP Core is subscribed
Review: Needs Fixing
Lines 494 onwards would be better formatted like below I think as it saves
using \ and we're all used to having and reading translate() calls needing
their own line.
self.tagTableWidget.horizontalHeaderItem(0).setText(
translate('OpenLP.DisplayTagTab', 'Description'))
Review: Needs Fixing
Merge conflicts
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50466
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Review: Needs Fixing
build_icon returns a QIcon, no need for all the QIcon(build_icon()) stuff.
Line 1070 is in UiStrings already as it's in the menu in mainwindow
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50469
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Needs Fixing
b%s/b
Please don't use b, use strong.
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/50469
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Needs Fixing
Bad indent 53
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49677
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Jon Tibble (meths)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more details,
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Jon Tibble (meths)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more details,
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49687
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49687
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49687
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49544
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49544
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49544
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
#716843
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49434
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49434
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/49434
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48825
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48825
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48692
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48692
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48692
Your team OpenLP Core is subscribed
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48707
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48707
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48631
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48631
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48631
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48112
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48112
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/48112
Your team OpenLP Core is subscribed
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47931
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47931
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
#710065
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47931
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47278
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47278
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47278
Your team OpenLP Core is subscribed
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47185
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more
Review: Needs Fixing
Don't need import - slidecontroller acts on actionList which is from
self.parent and never calls ActionList itself.
Lines 384 and 393 don't need \ inside brackets.
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47147
Your team OpenLP Core is subscribed to branch
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Jon Tibble (meths)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more details,
Review: Needs Fixing
Which exceptions are you catching? (lines 11 and 21) (KeyError maybe, not sure)
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47155
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Jon Tibble (meths)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more details,
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp.
Requested reviews:
Jon Tibble (meths)
Related bugs:
#693150 Custom Slide Display footer option
https://bugs.launchpad.net/bugs/693150
#693202 delete theme
https://bugs.launchpad.net/bugs/693202
For more details,
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47160
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47160
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47160
Your team OpenLP Core is subscribed
Review: Approve
Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47165
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47165
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/47165
Your team OpenLP Core is subscribed
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/bugs/+merge/46818
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
1 - 100 of 260 matches
Mail list logo
