The proposal to merge lp:~trb143/openlp/ft into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/189425
--
https://code.launchpad.net/~trb143/openlp/ft/+merge/189425
Your team OpenLP Core is subscribed to br
Review: Approve
Looks and works much better.
I know this is legacy, but we need to fix it in order to improve our tests:
883 + self.init_patcher =
patch('openlp.core.ui.formattingtagform.FormattingTagForm.__init__')
If we're mocking out __init__, we're doing it wrong. If you take a look at
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/189425
Review time.
This is a re-write of the Formatting tags UI.
Please
Oh, and there are some fixes for the tests (I implemented something of the sort
in my updated-mock branch), so let me know when you want to look at this and
I'll walk you through some of the refactoring we need to do.
--
https://code.launchpad.net/~trb143/openlp/ft/+merge/188207
Your team OpenLP
Review: Needs Fixing
Is this Python 2 or 3? Because I see some u'...' in there...
--
https://code.launchpad.net/~trb143/openlp/ft/+merge/188207
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-cor
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/188207
Review time.
This is a re-write of the Formatting tags UI.
Please review for usability and the
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/185661
Review time.
This is a re-write of the Formatting tags UI.
Please review for usability and the
One further bug.
1. Create a new tag.
2. Change the start html to ""
OpenLP reports that the start tag is invalid. not only that, but it also
renders the hr in the message box rather than the actual html code
--
https://code.launchpad.net/~trb143/openlp/ft/+merge/185138
Your team OpenLP Core is s
I like this! Just two small things.
I think "Default Formatting" sounds better than "Static Formatting"
A small usability issue:
1. Create a new tag
2. Click on the start html to edit it
3. Now click the delete button
OpenLP informs the user that the html is not valid.This is unnecessary as its
be
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/185138
Review time.
This is a re-write of the Formatting tags UI.
Please review for usability and the
Review: Needs Fixing
Bugs and doc string needs fixing. The other things are to be discussed.
--
https://code.launchpad.net/~trb143/openlp/ft/+merge/184486
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/
Code comments:
- Doc string o fsave_html_tags()
Bug:
1) Remove all tags
2) Save
3) Add a tag and save
4) Add another tag. And click save.
Result: A pop up saying that the last tag is already defined.
Rest:
1) I do not know how deep you looked at the code (vs just the GUI). What is
with this htm
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/184486
Review time.
This is a re-write of the Formatting tags UI.
Please review for usability and the us
413 +class EDITCOLUMN(object):
Why the all-caps?
--
https://code.launchpad.net/~trb143/openlp/ft/+merge/183545
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb143/openlp/ft into lp:openlp.
___
Mailing list: https://launch
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/183545
Review time.
This is a re-write of the Formatting tags UI.
Please review for usability and the us
Tim Bentley has proposed merging lp:~trb143/openlp/ft into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/ft/+merge/183366
Review time.
Still more tests to do but this is a re-write of the Formatting tags UI.
Please revi
16 matches
Mail list logo