The proposal to merge lp:~trb143/openlp/junefixes into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/176059
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/176059
Your team OpenLP Co
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/176059
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Related bugs:
Bug #1196926 in OpenLP: "Zero division error when display size set to zero"
https://bugs.launchpad.net/openlp/+bug/1196926
Bug #1197376 in OpenLP: "Typi
Review: Needs Fixing
Missing line (line 22/23).
Could you add a doc string to the method (it should be clear, why this method
exits)
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/175948
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1196926 in OpenLP: "Zero division error when display size set to zero"
https://bugs.launchpad.net/openlp/+bug/1196926
Bug #1197376 in OpenLP: "Typing
The proposal to merge lp:~trb143/openlp/junefixes into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/174598
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/174598
Your team OpenLP Co
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/174598
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1196926 in OpenLP: "Zero division error when display size set to zero"
https://bugs.launchpad.net/openlp/+bug/1196926
Bug #1197376 in OpenLP: "Typing
The proposal to merge lp:~trb143/openlp/junefixes into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172855
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172855
Your team OpenLP Co
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172855
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172855
Fix the broken test before Raoul rips it out
--
https://code.launchpad.net/~trb143
The proposal to merge lp:~trb143/openlp/junefixes into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172247
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172247
Your team OpenLP Co
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172247
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172247
Correct the application code so windows can invalida
Review: Needs Fixing
Started and then exited OpenLP...
Traceback (most recent call last):
File
"C:\Users\Jonathan\Documents\projects\openlp\junefixes\openlp\core\ui\mainwindow.py",
line 1036, in closeEvent
self.clean_up()
File
"C:\Users\Jonathan\Documents\projects\openlp\junefixes\open
Review: Needs Fixing
Ok, just remove the not needed import (line 7).
Also maybe an email to core mailing list?
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172230
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing li
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172230
Correct the application code so windows can invalidate application on exit.
Remov
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172229
Correct the application code so windows can invalidate application on exit.
Remov
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/172228
Correct the application code so windows can invalidate application on exit.
Remov
> Why bother this needs to be backported to 2.0 so will just be a delete.
You want to backport the json change???
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171319
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing l
Why bother this needs to be backported to 2.0 so will just be a delete.
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171319
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Or we just rework the third entry in the tuples (instead of "conversion rules"
add migration_function for all cases (you have to consider, that there is
currently just ONE case where we use the "conversion rules".
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171319
Your team Ope
My suggestion:
import types
__obsolete_settings__ = [
(u'displayTags/html_tags', u formatting_tags/html_tags', function_name)
]
And then in "remove_obsolete_settings":
if isinstance(rules, types.FunctionType):
rules() # Now, call function in Settings.py which does the migratio
Review: Needs Fixing
About the settings migration:
There is the obsolete settings list. Unfortunately this list is limited (in its
migration functionality).
*Maybe* we can add the migration could to the migration() method. *discussion
wanted*
--
https://code.launchpad.net/~trb143/openlp/junefix
Review: Needs Fixing
Line 55
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171319
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171319
Correct the application code so windows can invalidate application on exit.
Remov
Review: Needs Fixing
Works, but I think it would be better when you rename the setting. We reamed
"displayTags" to "formattingTags" so we could use this to rename the setting as
well. (I have to go now.)
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171139
Your team OpenLP Core
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171139
Correct the application code so windows can invalidate application on exit.
Removed
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/171132
Correct the application code so windows can invalidate application on exit.
Removed
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/170989
Correct the application code so windows can invalidate application on exit.
Removed
The proposal to merge lp:~trb143/openlp/junefixes into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/170684
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/170684
Your team OpenLP Co
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/170684
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/170684
Fix for presentation type
--
https://code.launchpad.net/~trb143/openlp/junefixes/+
The proposal to merge lp:~trb143/openlp/junefixes into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/169687
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/169687
Your team OpenLP Co
Review: Approve
Okay from me...
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/169687
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/169687
Fix minor bug from previous merge
Clean up slide controller methods
Add tests from
You've written an interface test, not a functional test. This doesn't just test
the code, it tests that the objects can query the websites. Our would be better
to mock out the Python library methods and supply our own HTML.
--
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/169681
You
Tim Bentley has proposed merging lp:~trb143/openlp/junefixes into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/junefixes/+merge/169681
Fix minor bug from previous merge
Clean up slide controller methods
Add tests from
38 matches
Mail list logo
