The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365879
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365879
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365879
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Some scrubbing on the nets found this:
avcapture://
--
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365879
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : ope
This is work in progress and needs 1 more merge to finish.
The commented our code is not needed and needs to be cleaned up but want to
keep till I finish.
The stream code is the next set and I have infor for linux and windows but not
mac. Did ask the mailing list and only tgc responded.
--
htt
Review: Needs Information
Overall this looks good. There is some commented code that I think either need
to be fixed or removed? Also, I noticed there's some code that deals with
streaming on Windows and Linux, which I presume you'll need the macOS
equivalent for. Is there any other code that y
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
VLC plays and handles missing live display gracefully. Preview still works.
Added experimental setting to remove UI incomplete stuff.
various bug fixes and improvments,
Requested reviews:
OpenLP Core
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
Phill (phill-ridout)
Related bugs:
Bug #1823575 in OpenLP: "PluginManager still has plugin list"
https://
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365762
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Just an FYI: I fixed those macOS tests, if you merge from trunk.
--
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365762
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365760
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
Phill (phill-ridout)
Related bugs:
Bug #1823575 in OpenLP: "PluginManager still has plugin list"
https://
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
Phill (phill-ridout)
Related bugs:
Bug #1823575 in OpenLP: "PluginManager still has plugin list"
https://
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365759
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
Phill (phill-ridout)
Related bugs:
Bug #1823575 in OpenLP: "PluginManager still has plugin list"
https://
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365193
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Hum no idea what is wrong. No enough info.
Need a trace but can you debug as there is no reason for the failure unless
something else is failing and not on the backtrace.
Your comments are either existing release code or WIP so will leave for now.
--
https://code.launchpad.net/~trb143/openlp/m
Couple of other small things
Diff comments:
>
> === added file 'openlp/core/ui/media/mediatab.py'
> --- openlp/core/ui/media/mediatab.py 1970-01-01 00:00:00 +
> +++ openlp/core/ui/media/mediatab.py 2019-03-27 19:21:41 +
> @@ -0,0 +1,147 @@
> +# -*- coding: utf-8 -*-
> +# vim: autoinden
Review: Needs Fixing
Sorry, that should have been a needs fixing!
Diff comments:
>
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py 2019-02-14 15:09:09 +
> +++ openlp/core/ui/media/mediacontroller.py 2019-03-27 19:21:41 +
>
Wont start on widnows 10
check_dependencies.py passes
Traceback (most recent call last):
File "C:/Users/sroom/Documents/Phill
Ridout/play_ground/openlp/media_state/run_openlp.py", line 71, in
start()
File "C:/Users/sroom/Documents/Phill
Ridout/play_ground/openlp/media_state/run_openlp.
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merg
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365192
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb14
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merg
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/365187
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb14
Tim Bentley has proposed merging lp:~trb143/openlp/media_state into lp:openlp.
Commit message:
Fix up VLC so it works and plays.
Still not finished but getting there.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merg
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361688
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361688
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361641
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361640
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361389
--
Your team OpenLP Core is subscribed to branch lp:openlp.
___
L7953: I'm not convinced the user will want to see a dialog box every time the
preview, go live, or edit a song that has audio
Could you comment this out for no, I'mo concerned that this would too easily be
overlooked. (Its only going to happen for people who try to load a song with
backgro
Review: Needs Information
I assume the commented out code is a work in progress?
L7027: if statement not needed
L7953: I'm not convinced the user will want to see a dialog box every time the
preview, go live, or edit a song that has audio
Also it looks like you've removed the background aud
Only got to line 1023, will take another look later, just a few minor issues
with doc strings (see inline comments)
Diff comments:
>
> === added file 'openlp/core/state.py'
> --- openlp/core/state.py 1970-01-01 00:00:00 +
> +++ openlp/core/state.py 2019-01-04 21:05:41 +
> @@ -
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/361345
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb14
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/359974
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb14
The proposal to merge lp:~trb143/openlp/media_state into lp:openlp has been
updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/media_state/+merge/359973
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~t
36 matches
Mail list logo
