[Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-04-04 Thread noreply
The proposal to merge lp:~trb143/openlp/pep8 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/pep8/+merge/214333 -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/214333 Your team OpenLP Core is subscribed

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-04-04 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/214333 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : h

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-04-04 Thread Raoul Snyman
11 + log_string = ('%s\n File %s at line %d \n\t called %s' % (log_string, tb[0], tb[1], tb[3])) Why the extra set of brackets? -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/213915 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/pep8 into l

[Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-22 Thread noreply
The proposal to merge lp:~trb143/openlp/pep8 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/pep8/+merge/212253 -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/212253 Your team OpenLP Core is subscribed

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-22 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/212253 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : h

[Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-18 Thread noreply
The proposal to merge lp:~trb143/openlp/pep8 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/pep8/+merge/211624 -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/211624 Your team OpenLP Core is subscribed

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-18 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/211624 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : h

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-18 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/211391 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : h

[Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-17 Thread noreply
The proposal to merge lp:~trb143/openlp/pep8 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/pep8/+merge/211166 -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/211166 Your team OpenLP Core is subscribed

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-16 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/211166 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : h

[Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-04 Thread noreply
The proposal to merge lp:~trb143/openlp/pep8 into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/pep8/+merge/209332 -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/209332 Your team OpenLP Core is subscribed

Re: [Openlp-core] [Merge] lp:~trb143/openlp/pep8 into lp:openlp

2014-03-04 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/pep8/+merge/209332 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : h

Re: [Openlp-core] [Merge] lp:~trb143/openlp/PEP8 into lp:openlp

2014-03-02 Thread Raoul Snyman
After running the functional tests and seeing confusion between various field names, I recommend you revert all of this, and start over using the refactor tool in PyCharm instead of find & replace. -- https://code.launchpad.net/~trb143/openlp/PEP8/+merge/208960 Your team OpenLP Core is requested

Re: [Openlp-core] [Merge] lp:~trb143/openlp/PEP8 into lp:openlp

2014-03-02 Thread Raoul Snyman
Sometimes, the method name is so long the arguments look a little silly. In these cases, instead of doing this: folder = QtGui.QFileDialog.getExistingDirectory(self, title, Settings().value(self.plugin.settings_section +