[Openlp-core] [Merge] lp:~trb143/openlp/singleton into lp:openlp

2013-01-24 Thread noreply
The proposal to merge lp:~trb143/openlp/singleton into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~trb143/openlp/singleton/+merge/144796 -- https://code.launchpad.net/~trb143/openlp/singleton/+merge/144796 Your team OpenLP Co

Re: [Openlp-core] [Merge] lp:~trb143/openlp/singleton into lp:openlp

2013-01-24 Thread Raoul Snyman
Review: Approve Well, all the tests pass, but this line looks a little weird to me: self.assertEqual(context.exception[0], u'Service test2 not found in list') -- https://code.launchpad.net/~trb143/openlp/singleton/+merge/144796 Your team OpenLP Core is subscribed to branch lp:openlp. __

Re: [Openlp-core] [Merge] lp:~trb143/openlp/singleton into lp:openlp

2013-01-24 Thread Raoul Snyman
Review: Needs Fixing Oh, and you're testing the registry, so please name your TestCase accordingly (and update your docstrings!)... 2255+class TestServiceItem(TestCase): -- https://code.launchpad.net/~trb143/openlp/singleton/+merge/144640 Your team OpenLP Core is subscribed to branch lp:ope

Re: [Openlp-core] [Merge] lp:~trb143/openlp/singleton into lp:openlp

2013-01-24 Thread Raoul Snyman
Review: Needs Fixing 437 + if key in self.service_list: 438 + log.error(u'Duplicate service exception %s' % key) 439 + raise Exception(u'Duplicate service exception %s' % key) Rather raise a more specific exception, like KeyError. 2271+ # WHEN: I add a service it should save it