The proposal to merge lp:~trb143/openlp/theme-cleanup into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/200079
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/200079
Your te
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/200079
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
The proposal to merge lp:~trb143/openlp/theme-cleanup into lp:openlp has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/200054
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/2000
The proposal to merge lp:~trb143/openlp/theme-cleanup into lp:openlp has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/200028
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/2000
The proposal to merge lp:~trb143/openlp/theme-cleanup into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/198115
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/198115
Your te
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/198115
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
Tim Bentley has proposed merging lp:~trb143/openlp/theme-cleanup into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/198115
Start of the ThemeManager refactor.
Add helper which has no UI code.
Add
Review: Needs Fixing
'The function build_theme_path should have been called'
Be a little more specific in your messages: 'The function build_theme_path
should have been called once' -- this way when the test fails we know exactly
why.
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/
Tim Bentley has proposed merging lp:~trb143/openlp/theme-cleanup into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/193719
Start of the ThemeManager refactor.
Add helper which has no UI code.
Add t
The proposal to merge lp:~trb143/openlp/theme-cleanup into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/191850
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/191850
Your te
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/theme-cleanup/+merge/191850
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
No.
That is how json stores and manages the info and passes it out via reflection.
Your suggestion continues with the mistake of XML where a parser was needed to
build and prime the internal variables.
The change is to make it easier to add varabiles to themes at present it is not
simple as the
Review: Needs Fixing
Is openlp/core/lib/json/theme.json your JSON? Can we please make it a little
pretter?
{
"background": {
"type": "image",
"image: "/home/raoul/pic.png"
},
"font": {
...
},
...
}
--
https://code.launchpad.net/~trb143/openlp/theme-cl
13 matches
Mail list logo
