Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Szymon Modzelewski
> A comment to the status handler. I think if the status byte from the get > status is not zero the > command always fails. There are 3 documented cases, 0 ok, 1 command error, 2 > phase error. > You mean documented in "USB Mass Storage Class – Bulk Only Transport", right? I'd say it's entirely

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Mathias K.
No, i never run into the sense command handler, thats the problem. A comment to the status handler. I think if the status byte from the get status is not zero the command always fails. There are 3 documented cases, 0 ok, 1 command error, 2 phase error. On 21.02.2012 20:37, Szymon Modzelewski w

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Spencer Oliver
On Feb 21, 2012 7:45 PM, "Szymon Modzelewski" wrote: > > > NB2! You can't send patches to the mailing list anymore at all. > > Whoops. Maybe you should update the page here: > http://openocd.sourceforge.net/discussion/mailing-lists/ > > It says the mailing list is still the appropriate place to se

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Szymon Modzelewski
> NB2! You can't send patches to the mailing list anymore at all. Whoops. Maybe you should update the page here: http://openocd.sourceforge.net/discussion/mailing-lists/ It says the mailing list is still the appropriate place to send patches. -

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Szymon Modzelewski
> > Did you test command errors without the scsi sense command? > Do you have any specific test case in mind? The memory writes were failing in stlink_usb_recv_v1_get_status If I send a deliberately malformed command it fails in get_status or even earlier. I don't know how to trigger the sense

[OpenOCD-devel] [PATCH]: bfbc1b8 stlink-v1: fix memory writes

2012-02-21 Thread gerrit
This is an automated email from Gerrit. Anonymous Coward (szmodzelew...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/478 -- gerrit commit bfbc1b8a0e350e83de975fb57b3c7b2aa9adf3d9 Author: Szymon Modzelewski Date: Tue Feb 21 13:44:00 2012 +

[OpenOCD-devel] [PATCH]: c4434e0 stlink-v1: code cleanup

2012-02-21 Thread gerrit
This is an automated email from Gerrit. Anonymous Coward (szmodzelew...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/477 -- gerrit commit c4434e013793515264cb0d009cc0cc0b350e34ec Author: Szymon Modzelewski Date: Tue Feb 21 13:43:11 2012 +

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Mathias K.
The prepend would make the source more transparent. Szymon: Did you test command errors without the scsi sense command? On 21.02.2012 18:19, Uwe Bonnes wrote: >> "Szymon" == Szymon Modzelewski writes: > > Szymon> Hi, On Tue, Feb 21, 2012 at 11:10 AM, Uwe Bonnes > Szymon> wrote: >

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Uwe Bonnes
> "Szymon" == Szymon Modzelewski writes: Szymon> On Tue, Feb 21, 2012 at 8:13 AM, Mathias K. Szymon> wrote: >> You should look into texane sources. The function in question is >> named "get_sense". Szymon> I was actually looking at stlink-usb.c (it has v1 paths too),

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Uwe Bonnes
> "Szymon" == Szymon Modzelewski writes: Szymon> Hi, On Tue, Feb 21, 2012 at 11:10 AM, Uwe Bonnes Szymon> wrote: >> You can also use the V2 code path and prepend the SCSI header to V1 >> cables, as I have implemented in current stlink git. So no more code >> duplication.

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Spencer Oliver
On 21 February 2012 16:48, Szymon Modzelewski wrote: > Changed patch to actually match the description inside. > > Sorry for the noise. > Thanks, can you upload to our gerrit server for review? http://openocd.sourceforge.net/doc/doxygen/html/patchguide.html Cheers Spen

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Szymon Modzelewski
Changed patch to actually match the description inside. Sorry for the noise. From 505fc4df12a78c41e2d2c5ac0e0add27733587aa Mon Sep 17 00:00:00 2001 From: szmodzelewski Date: Tue, 21 Feb 2012 13:43:11 +0100 Subject: [PATCH 1/2] stlink-v1: code cleanup This patch moves the bulk of the stlink read/

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Szymon Modzelewski
Hi, On Tue, Feb 21, 2012 at 11:10 AM, Uwe Bonnes wrote: > You can also use the V2 code path and prepend the SCSI header to V1 cables, > as I have implemented in current stlink git. So no more code duplication. I was actually reading that code to fix openocd. However, I don't think that the appro

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Szymon Modzelewski
On Tue, Feb 21, 2012 at 8:13 AM, Mathias K. wrote: > > You should look into texane sources. The function in question is named > "get_sense". I was actually looking at stlink-usb.c (it has v1 paths too), which doesn't have any equivalent of that function. I've added an implementation based on st

Re: [OpenOCD-devel] pic32mx220f032b better flash support

2012-02-21 Thread Spencer Oliver
On 20 February 2012 18:22, salvador wrote: > Hello > I have made same minor changes to make a better support for flashing a > pic32mx220f032b chip. > This chip has 3k boot flash, 32k program flash an 8k ram. OpenOCD does at the moment have an issue with the BFM size register - i am trying to get

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Mathias K.
Hello, i try to figure out if your v2 code path works with stm8l (stlink v1) too. What i can see, except some not supported things, the get version command works, the correct buffer was returned (0x10 0x03 0x83 0x04 0x44 0x37). So things can be made simpler in openocd. Regards, Mathias On 2

Re: [OpenOCD-devel] pic32mx220f032b better flash support

2012-02-21 Thread Spencer Oliver
On 20 February 2012 18:57, Peter Stuge wrote: >> Please read the file called HACKING in OpenOCD on how to >> submit it to Gerrit for review. > > Note that anyone else can also create the patch according to those > guidelines and submit to Gerrit on behalf of the original poster! > ditto :-) Spen

Re: [OpenOCD-devel] Stm32lx Flash script

2012-02-21 Thread Spencer Oliver
On 21 February 2012 05:48, Noel Diviney wrote: > > In this case the "stopped,reason" is breakpoint-hit whereas "stopped,reason" > for the stlink-v2 discovery is "signal-received" . > What I have to do now is correct my CodeLite dll to correctly handle all of > the "stopped, reason"'s and I should

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Uwe Bonnes
> "Mathias" == Mathias K writes: Mathias> Hello, this doesn't work for stm8l yet: Mathias> 2012-02-21T11:37:53 DEBUG src/stlink-common.c: st vid = 0x0483 Mathias> (expect 0x0483) 2012-02-21T11:37:53 DEBUG src/stlink-common.c: Mathias> stlink pid = 0x3744 2012-02-21T11:37:53 D

[OpenOCD-devel] [PATCH]: 56e9731 docs: fix more texinfo warnings

2012-02-21 Thread gerrit
This is an automated email from Gerrit. Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/475 -- gerrit commit 56e97310054fadd863731cf7844088007e6441d4 Author: Spencer Oliver Date: Tue Feb 21 10:34:48 2012 +

[OpenOCD-devel] [PATCH]: dae2ffe stlink: support expected-id 0

2012-02-21 Thread gerrit
This is an automated email from Gerrit. Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/476 -- gerrit commit dae2ffe4d85f4ac43ab5ba2ab4a6552feadd7c2a Author: Spencer Oliver Date: Tue Feb 21 10:41:39 2012 +

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Mathias K.
Hello, this doesn't work for stm8l yet: 2012-02-21T11:37:53 DEBUG src/stlink-common.c: st vid = 0x0483 (expect 0x0483) 2012-02-21T11:37:53 DEBUG src/stlink-common.c: stlink pid = 0x3744 2012-02-21T11:37:53 DEBUG src/stlink-common.c: stlink version = 0x1 2012-02-21T11:37:53 DEBUG src/

[OpenOCD-devel] [PATCH]: 2e03204 jtag: fix cmd scan_chain expected_ids bug

2012-02-21 Thread gerrit
This is an automated email from Gerrit. Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/474 -- gerrit commit 2e03204f19fc3cb76b7e218d738e650d23d77f04 Author: Spencer Oliver Date: Tue Feb 21 10:16:27 2012 +

[OpenOCD-devel] [PATCH]: daad941 jtag: use correct tap -ignore-version mask

2012-02-21 Thread gerrit
This is an automated email from Gerrit. Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/473 -- gerrit commit daad941787aed882b539d5aa7c89a308f770788e Author: Spencer Oliver Date: Tue Feb 21 10:13:21 2012 +

Re: [OpenOCD-devel] stlink-v1 broken

2012-02-21 Thread Uwe Bonnes
> "Szymon" == Szymon Modzelewski writes: Szymon> Hi all, The current openocd git doesn't have usable stlink-v1 Szymon> support. Szymon> Memory writes are completely broken (meaning they don't work at Szymon> all). The current code tries to issue two SG commands and check