This is an automated email from Gerrit.

Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/426

-- gerrit

commit 90fd0ebe26169ea0d24ff91d3cc24f156779fa65
Author: Spencer Oliver <s...@spen-soft.co.uk>
Date:   Thu Feb 2 15:04:42 2012 +0000

    checkpatch: remove static const char checks
    
    Change-Id: I2d313fe4ce250332b0d99282f67c3ecd678e8773
    Signed-off-by: Spencer Oliver <s...@spen-soft.co.uk>

diff --git a/tools/scripts/checkpatch.pl b/tools/scripts/checkpatch.pl
index 7c67cd0..7127c8f 100755
--- a/tools/scripts/checkpatch.pl
+++ b/tools/scripts/checkpatch.pl
@@ -2100,24 +2100,24 @@ sub process {
                }
 
 # check for static const char * arrays.
-               if ($line =~ 
/\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
-                       WARN("STATIC_CONST_CHAR_ARRAY",
-                            "static const char * array should probably be 
static const char * const\n" .
-                               $herecurr);
-               }
+#              if ($line =~ 
/\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
+#                      WARN("STATIC_CONST_CHAR_ARRAY",
+#                           "static const char * array should probably be 
static const char * const\n" .
+#                              $herecurr);
+#               }
 
 # check for static char foo[] = "bar" declarations.
-               if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
-                       WARN("STATIC_CONST_CHAR_ARRAY",
-                            "static char array declaration should probably be 
static const char\n" .
-                               $herecurr);
-               }
+#              if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
+#                      WARN("STATIC_CONST_CHAR_ARRAY",
+#                           "static char array declaration should probably be 
static const char\n" .
+#                              $herecurr);
+#               }
 
 # check for declarations of struct pci_device_id
-               if ($line =~ 
/\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
-                       WARN("DEFINE_PCI_DEVICE_TABLE",
-                            "Use DEFINE_PCI_DEVICE_TABLE for struct 
pci_device_id\n" . $herecurr);
-               }
+#              if ($line =~ 
/\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
+#                      WARN("DEFINE_PCI_DEVICE_TABLE",
+#                           "Use DEFINE_PCI_DEVICE_TABLE for struct 
pci_device_id\n" . $herecurr);
+#              }
 
 # check for new typedefs, only function parameters and sparse annotations
 # make sense.

-- 

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to