Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-15 Thread Hsiangkai Wang
Hi, Franck, I merged your modification to http://openocd.zylin.com/#/c/1382/ Please help me to review it. Thanks. 2013/6/13 Franck Jullien > > > > 2013/6/13 Andreas Fritiofson > >> >> On Thu, Jun 13, 2013 at 9:35 AM, Franck Jullien > > wrote: >> >>> >>> 2013/6/13 Andreas Fritiofson >>>

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-13 Thread Franck Jullien
2013/6/13 Andreas Fritiofson > > On Thu, Jun 13, 2013 at 9:35 AM, Franck Jullien > wrote: > >> >> 2013/6/13 Andreas Fritiofson >> >>> On Thu, Jun 13, 2013 at 9:18 AM, Franck Jullien < >>> franck.jull...@gmail.com> wrote: >>> 2013/6/13 Andreas Fritiofson > > Why change re

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-13 Thread Andreas Fritiofson
On Thu, Jun 13, 2013 at 9:35 AM, Franck Jullien wrote: > > 2013/6/13 Andreas Fritiofson > >> On Thu, Jun 13, 2013 at 9:18 AM, Franck Jullien > > wrote: >> >>> >>> 2013/6/13 Andreas Fritiofson >>> Why change reg_group from enum to string? According to gdb docs it can only take one

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-13 Thread Franck Jullien
2013/6/13 Andreas Fritiofson > On Thu, Jun 13, 2013 at 9:18 AM, Franck Jullien > wrote: > >> >> >> >> 2013/6/13 Andreas Fritiofson >> >>> >>> >>> >>> On Sun, Jun 9, 2013 at 7:21 PM, wrote: >>> -enum reg_group { - REG_GROUP_GENERAL, - REG_GROUP_FLOAT, -

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-13 Thread Andreas Fritiofson
On Thu, Jun 13, 2013 at 9:18 AM, Franck Jullien wrote: > > > > 2013/6/13 Andreas Fritiofson > >> >> >> >> On Sun, Jun 9, 2013 at 7:21 PM, wrote: >> >>> >>> -enum reg_group { >>> - REG_GROUP_GENERAL, >>> - REG_GROUP_FLOAT, >>> - REG_GROUP_VECTOR, >>> -}; >>> - >>> struct reg_fe

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-13 Thread Franck Jullien
2013/6/13 Andreas Fritiofson > > > > On Sun, Jun 9, 2013 at 7:21 PM, wrote: > >> >> -enum reg_group { >> - REG_GROUP_GENERAL, >> - REG_GROUP_FLOAT, >> - REG_GROUP_VECTOR, >> -}; >> - >> struct reg_feature { >> const char *name; >> }; >> @@ -129,7 +123,7 @@ struct reg

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-13 Thread Andreas Fritiofson
On Sun, Jun 9, 2013 at 7:21 PM, wrote: > > -enum reg_group { > - REG_GROUP_GENERAL, > - REG_GROUP_FLOAT, > - REG_GROUP_VECTOR, > -}; > - > struct reg_feature { > const char *name; > }; > @@ -129,7 +123,7 @@ struct reg { > bool valid; > uint32_t size; >

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-12 Thread Franck Jullien
Great ! Thanks. 2013/6/13 Hsiangkai Wang > Hi, Franck, > > I agree your enhancement. I will do some modification and merge your > patch in commit 1382. > Thanks. > > 2013/6/10 Franck Jullien > >> H >> siangkai Wang, >> >> Could you try this patch on your target ? It implies only some minor >>

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-12 Thread Hsiangkai Wang
Hi, Franck, I agree your enhancement. I will do some modification and merge your patch in commit 1382. Thanks. 2013/6/10 Franck Jullien > H > siangkai Wang, > > Could you try this patch on your target ? It implies only some minor > changes in your target code. > This way, the tdesc thing will

Re: [OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-09 Thread Franck Jullien
H siangkai Wang, Could you try this patch on your target ? It implies only some minor changes in your target code. This way, the tdesc thing will be compatible with my openrisc port. Thanks. 2013/6/9 > From: Franck Jullien > > This patch adds the possibility to create feature sections > from

[OpenOCD-devel] [PATCH] gdb_server: automatically create feature sections

2013-06-09 Thread franck . jullien
From: Franck Jullien This patch adds the possibility to create feature sections from the feature name. The feature name can be anything. It also adds a command to save the tdesc file (for debug purpose). Change-Id: I47f51028c6a1a2a2bb41e61170438e576eb05890 Signed-off-by: Franck Jullien --- sr