[Openocd-development] [PATCH 3/4] - Fixes '[|]' whitespace

2009-06-17 Thread Zach Welch
- Fixes '[|]' whitespace - Replace ')\([|]\)(' with ') \1 ('. - Replace ')\([|]\)\(\w\)' with ') \1 \2'. - Replace '\(\w\)\([|]\)(' with '\1 \2 ('. - Replace '\(\w\)\([|]\)\(\w\)' with '\1 \2 \3'. --- ecosboard.c|2 +- flash/at91sam7.c |6 +++--- flash/fla

[Openocd-development] [SERIES 4/4] Fix miscellaneous whitespace issues.

2009-06-17 Thread Zach Welch
Fix miscellaneous whitespace issues. 1/5 Remove whitespace that occurs after '('. 2/5 Remove whitespace that occurs before ')'. 3/5 - Replace '){' with ') {'. 4/5 Remove whitespace at end of lines, step 1. 5/5 Remove whitespace at end of lines, step 2. --- Summary of Patches 1-

[Openocd-development] [SERIES 3/4] Fix one-character binary operator whitespace.

2009-06-17 Thread Zach Welch
Fix one-character binary operator whitespace issues throughout the tree: 1/4 - Fixes '=' whitespace 2/4 - Fixes '+' whitespace 3/4 - Fixes '[|]' whitespace 4/4 - Fixes '[<>]' whitespace --- Summary of Patches 1-4: doc/manual/style.txt |7 src/ecosboard.c

[Openocd-development] [PATCH 9/10] - Fixes '<<' whitespace

2009-06-17 Thread Zach Welch
- Fixes '<<' whitespace - Replace ')\(<<\)\(\w\)' with ') \1 \2'. - Replace '\(\w\)\(<<\)(' with '\1 \2 ('. - Replace '\(\w\)\(<<\)\(\w\)' with '\1 \2 \3'. --- flash/at91sam7.c |2 flash/cfi.c|2 flash/non_cfi.c|2 flash/ocl.c

[Openocd-development] [PATCH 7/10] - Fixes '<=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '<=' whitespace - Replace '\(\w\)\(<=\)\(\w\)' with '\1 \2 \3'. --- flash/at91sam7.c |4 ++-- helper/jim.c |4 ++-- jtag/bitq.c|2 +- target/arm7_9_common.c |6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) Fix two-character binary oper

[Openocd-development] [PATCH 8/10] - Fixes '>>' whitespace

2009-06-17 Thread Zach Welch
- Fixes '>>' whitespace - Replace ')\(>>\)\(\w\)' with ') \1 \2'. - Replace '\(\w\)\(>>\)(' with '\1 \2 ('. - Replace '\(\w\)\(>>\)\(\w\)' with '\1 \2 \3'. --- flash/at91sam7.c | 42 - flash/flash.c |4 +-- flash/ocl/at91

[Openocd-development] [PATCH 6/10] - Fixes '>=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '>=' whitespace - Replace ')\(>=\)\(\w\)' with ') \1 \2'. - Replace '\(\w\)\(>=\)\(\w\)' with '\1 \2 \3'. --- flash/ocl/at91sam7x/samflash.c |2 +- helper/jim.c |4 ++-- jtag/bitq.c|2 +- jtag/presto.c |4 ++-- target/a

[Openocd-development] [PATCH 5/10] - Fixes '&&' whitespace

2009-06-17 Thread Zach Welch
- Fixes '&&' whitespace - Replace ')\(&&\)(' with ') \1 ('. - Replace '\(\w\)\(&&\)(' with '\1 \2 ('. - Replace '\(\w\)\(&&\)\(\w\)' with '\1 \2 \3'. --- flash/at91sam7.c |2 +- helper/binarybuffer.h |4 ++-- helper/ioutil.c |4 ++-- jtag/core.c

[Openocd-development] [PATCH 4/10] - Fixes '[*]=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '[*]=' whitespace - Replace '\(\w\)\([*]=\)\(\w\)' with '\1 \2 \3'. --- cfi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Fix two-character binary operator whitespace issues throughout the tree: - Fixes '[*]=' whitespace - Replace '\(\w\)\([*]=\)\(\w\)' with '\1 \2 \3'. --- c

[Openocd-development] [PATCH 3/10] - Fixes '[+]=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '[+]=' whitespace - Replace '\(\w\)\([+]=\)(' with '\1 \2 ('. - Replace '\(\w\)\([+]=\)\(\w\)' with '\1 \2 \3'. --- flash/cfi.c|2 +- flash/ecos.c |2 +- flash/mflash.c |2 +- flash/ocl/at91sam7x/main.c |2 +- flash/

[Openocd-development] [PATCH 1/10] - Fixes '-=' whitespace

2009-06-17 Thread Zach Welch
- Fixes '-=' whitespace - Replace '\(\w\)\(-=\)(' with '\1 \2 ('. - Replace '\(\w\)\(-=\)\(\w\)' with '\1 \2 \3'. --- server/telnet_server.c |2 +- target/image.c |2 +- target/target.c|8 3 files changed, 6 insertions(+), 6 deletions(-) Fix two-character binar

[Openocd-development] [SERIES 2/4] Fix two-character binary operator whitespace

2009-06-17 Thread Zach Welch
Fix two-character binary operator whitespace issues throughout the tree: 1/10- Fixes '-=' whitespace 2/10- Fixes '!=' whitespace 3/10- Fixes '[+]=' whitespace 4/10- Fixes '[*]=' whitespace 5/10- Fixes '&&' whitespace 6/10- Fixes '>=' whitespace 7/10- Fixes '<=' whitespa

[Openocd-development] [PATCH 4/5] - Replace 'for(' with 'for ('.

2009-06-17 Thread Zach Welch
- Replace 'for(' with 'for ('. --- src/flash/cfi.c |4 ++-- src/flash/flash.c |4 ++-- src/flash/nand_ecc.c |2 +- src/flash/pic32mx.c |4 ++-- src/helper/jim.c |8 src/he

[Openocd-development] [PATCH 3/5] - Replace 'switch(' with 'switch ('.

2009-06-17 Thread Zach Welch
- Replace 'switch(' with 'switch ('. --- flash/cfi.c | 24 +++--- flash/ecos.c |2 - flash/flash.c |4 +- flash/mflash.c|2 - flash/stm32x.c|8 ++-- helper/jim.c | 78 +++

[Openocd-development] [PATCH 5/5] - Replace 'do{' with 'do ('.

2009-06-17 Thread Zach Welch
- Replace 'do{' with 'do {'. - Replace '}while' with '} while'. --- avrf.c|8 lpc288x.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) - Replace 'do{' with 'do {'. - Replace '}while' with '} while'. --- avrf.c|8 lpc288x.c |2 +- 2 files changed,

[Openocd-development] [PATCH 2/5] - Replace 'while(' with 'while ('.

2009-06-17 Thread Zach Welch
- Replace 'while(' with 'while ('. --- src/flash/avrf.c |6 +- src/flash/pic32mx.c |2 src/flash/stellaris.c|6 +- src/flash/str7x.c|2 src/flash/str9x.c|2 src/f

[Openocd-development] [SERIES 1/4] Fix whitespace around flow-control keywords.

2009-06-17 Thread Zach Welch
Fix whitespace around if/while/for flow control statements. 1/5 - Replace 'if(' with 'if ('. 2/5 - Replace 'while(' with 'while ('. 3/5 - Replace 'switch(' with 'switch ('. 4/5 - Replace 'for(' with 'for ('. 5/5 - Replace 'do{' with 'do ('. --- Summary of Patches 1-5: doc/manu

[Openocd-development] [SERIES 0/4] Whitespace Cleaning

2009-06-17 Thread Zach Welch
The following chain of patch series performs tree-wide whitespace clean-up, using systematic search and replacement (i.e. sed). It must be applied on top of the last series that changes the types. The patches in these series have been reviewed to ensure there are no adverse affects. Some operator

Re: [Openocd-development] Idea on dr/irscan command handling

2009-06-17 Thread David Brownell
On Monday 15 June 2009, Laurent Gauch wrote: > It could be don't care, but it will be better to fix/drive TMS at '1'. > Putting the JTAG TAP in RESET State. > > After JTAG power domain sequence (100x TCK TMS '1'), we will enter in > JTAG Startup sequence (Minimum of 5x TCK with TMS at '1'). Or

[Openocd-development] [PATCH 11/11] Update Style Guide documentation to explain basic type rules.

2009-06-17 Thread Zach Welch
Update Style Guide documentation to explain basic type rules. --- style.txt |7 +++ 1 file changed, 7 insertions(+) Update Style Guide documentation to explain basic type rules. --- style.txt |7 +++ 1 file changed, 7 insertions(+) == only in patch2: unchanged: --- doc/manual/

[Openocd-development] [PATCH 8/11] Finish transforming 'u32' to 'uint32_t'.

2009-06-17 Thread Zach Welch
Finish transforming 'u32' to 'uint32_t'. - Replace '\([^_]\)u32' with '\1uint32_t'. - Replace '^u32' with 'uint32_t'. --- helper/binarybuffer.c| 18 helper/binarybuffer.h| 14 ++--- helper/fileio.c | 22 ++-- h

[Openocd-development] [PATCH 10/11] Remove redundant typedefs in types.h; include stdint.h unconditionally.

2009-06-17 Thread Zach Welch
Remove redundant typedefs in types.h; include stdint.h unconditionally. --- types.h | 18 -- 1 file changed, 18 deletions(-) Remove redundant typedefs in types.h; include stdint.h unconditionally. --- types.h | 18 -- 1 file changed, 18 deletions(-) == diff

[Openocd-development] [PATCH 9/11] Transform 'u64' to 'uint64_t'

2009-06-17 Thread Zach Welch
Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++-- target/trace.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++-- target/trace

[Openocd-development] [PATCH 0/11] Change types from uN to uintN_t (take 2)

2009-06-17 Thread Zach Welch
Switch integer types to use C99 portable types. Despite my previous preference for the existing types, the fact remains that the standard types offer sufficient advantages to compel their use. For example, the new number parsing helper functions use these secondary definitions to support range che

[Openocd-development] [patch] openocd.texi - src/pld doc

2009-06-17 Thread David Brownell
The PLD stuff hasn't been documented yet. It's just Virtex2 for now, but it looks like adding others would be easy. --- doc/openocd.texi | 57 + 1 file changed, 57 insertions(+) The PLD stuff hasn't been documented yet. It's just Virtex2 fo

[Openocd-development] [patch] src/pld cleanups

2009-06-17 Thread David Brownell
Clean up the PLD files: - Get rid of some extraneous whitespace - Make various functions static - Wrap overlong lines --- src/pld/pld.c| 68 ++--- src/pld/virtex2.c| 47 ++--- src/pld/xilinx_bit.c | 39 ++

[Openocd-development] gdb error: Error: Load failed

2009-06-17 Thread Gene Smith
I now have a problem on windows (ok on linux) that when I do a load of my elf file (to flash on cortex m3) I get the errors on openocd: Error: AHBAP Cached values: dp_select 0x0, ap_csw 0xa212, ap_tar 0x Error: SWJ-DP STICKY ERROR Error: Read MEM_AP_CSW 0x2352, MEM_AP_TAR 0x8

[Openocd-development] [patch 2/2] openocd.texi cleanup

2009-06-17 Thread David Brownell
Various bits of cleanup, mostly to match the style hints I just got around to writing up. - Various @cindex improvements - Cross reference the command line options in a few spots, notably for @command{debug_level} - Clean the config file guidelines a bit: * They're for all users, not

[Openocd-development] [patch 1/2] texi style guide info

2009-06-17 Thread David Brownell
Take a whack at providing some texinfo style docs. Mostly it's just basic "how 2 write sane dox" stuff. --- doc/manual/primer/docs.txt | 10 ++-- doc/manual/style.txt | 98 ++- 2 files changed, 102 insertions(+), 6 deletions(-) Take a whack at pr

[Openocd-development] r2269 build error (need --disable-werror ?)

2009-06-17 Thread Gene Smith
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../src/helper -I../../src/target -g -O2 -Wall -Wstrict-prototypes -Wformat-security -Wextra -Wno-unused-parameter -Wbad-function-cast -Wcast-align -Wredundant-decls -Werror -MT tcl.lo -MD -MP -MF .deps/tcl.Tpo -c tcl.c -o tcl.o tcl.c: In functio

Re: [Openocd-development] LPC2478.cfg patch

2009-06-17 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] LPC2478.cfg patch

2009-06-17 Thread Freddie Chopin
I attach a patch which makes lpc2478.cfg file more "standard" and - what is most important - correct (it's working [; ). I've also added some comments which try to clarify the meaning of all that's in there. 4\/3!! Index: tcl/target/lpc2478.cfg ==

Re: [Openocd-development] Error recovery

2009-06-17 Thread Rick Altherr
On Jun 17, 2009, at 4:51 AM, Audrius Urmanavičius wrote: On Tue, Jun 16, 2009 at 11:04 PM, Rick Altherr wrote: On Jun 16, 2009, at 11:06 AM, Gene Smith wrote: At this time openocd is working quite well for me with 3 different jtag adapters: rlink, jlink and olimex/ftdi. However, I ha

Re: [Openocd-development] Problem with r2252 and mww

2009-06-17 Thread Michael Fischer
Hello Zach, the version r2268 is working here now. Best regards, Michael -Ursprüngliche Nachricht- Von: Zach Welch [mailto:z...@superlucidity.net] Gesendet: Mittwoch, 17. Juni 2009 02:38 An: Michael Fischer Cc: Openocd-Dev Betreff: Re: [Openocd-development] Problem with r2252 and mww

Re: [Openocd-development] [patch 3/5] beagle config file updates

2009-06-17 Thread Dirk Behme
David Brownell wrote: > Update the Beagle setup: > > - OMAP3530 updates: > * split ICEpick TAP enable support to its own file, for > reuse and eventually for storing other utility code > like emulation reset > * clean up, including labeling the tap as for DAP not > for t

Re: [Openocd-development] [PATCH 0/6] [C99] change types from uN to uintN_t

2009-06-17 Thread Zach Welch
On Wed, 2009-06-17 at 06:22 -0700, Zach Welch wrote: > Switch integer types to use C99 portable types. > > Despite my previous preference for the existing types, the fact remains > that the standard types offer sufficient advantages to compel their use. > For example, the new number parsing helper

[Openocd-development] [PATCH 5/6] Remove redundant typedefs in types.h; include stdint.h unconditionally.

2009-06-17 Thread Zach Welch
Remove redundant typedefs in types.h; include stdint.h unconditionally. --- types.h | 18 -- 1 file changed, 18 deletions(-) Remove redundant typedefs in types.h; include stdint.h unconditionally. --- types.h | 18 -- 1 file changed, 18 deletions(-) == diff

[Openocd-development] [PATCH 6/6] Update Style Guide documentation to explain basic type rules.

2009-06-17 Thread Zach Welch
Update Style Guide documentation to explain basic type rules. --- style.txt |7 +++ 1 file changed, 7 insertions(+) Update Style Guide documentation to explain basic type rules. --- style.txt |7 +++ 1 file changed, 7 insertions(+) == only in patch2: unchanged: --- doc/manual/

[Openocd-development] [PATCH 4/6] Transform 'u64' to 'uint64_t'

2009-06-17 Thread Zach Welch
Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++-- target/trace.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Transform 'u64' to 'uint64_t' - Replace '\([^_]\)u64' with '\1uint64_t'. --- helper/types.h |4 ++-- target/trace

[Openocd-development] [PATCH 0/6] [C99] change types from uN to uintN_t

2009-06-17 Thread Zach Welch
Switch integer types to use C99 portable types. Despite my previous preference for the existing types, the fact remains that the standard types offer sufficient advantages to compel their use. For example, the new number parsing helper functions use these secondary definitions to support range che

Re: [Openocd-development] Error recovery

2009-06-17 Thread Audrius Urmanavičius
On Tue, Jun 16, 2009 at 11:04 PM, Rick Altherr wrote: > > On Jun 16, 2009, at 11:06 AM, Gene Smith wrote: > > At this time openocd is working quite well for me with 3 different jtag >> adapters: rlink, jlink and olimex/ftdi. However, I have noticed a couple >> of error recovery situations where i

Re: [Openocd-development] Nit to pick with recent set of cleanups

2009-06-17 Thread Rick Altherr
On Jun 17, 2009, at 12:32 AM, Michael Schwingen wrote: - If you are testing that a variable is non-NULL, write that. Similarly for a test for NULL. Taking the short-cut just makes it less clear what you are doing and why. Besides, it isn't necessarily guaranteed that NULL will always be 0. ;

Re: [Openocd-development] Nit to pick with recent set of cleanups

2009-06-17 Thread Timothy Clacy
> Rick Altherr wrote: > > I personally find the excerpted line confusing and clunky. I _do_ > > know what it does, but only because I've written the exact > same code > > to handle the error cases returned by stroul. Without > seeing the rest > > of the code, here's what I don't like about i

Re: [Openocd-development] Nit to pick with recent set of cleanups

2009-06-17 Thread Michael Schwingen
Rick Altherr wrote: > I personally find the excerpted line confusing and clunky. I _do_ > know what it does, but only because I've written the exact same code > to handle the error cases returned by stroul. Without seeing the rest > of the code, here's what I don't like about it: > - okay is