Re: [Openocd-development] multiple JTAG interfaces

2009-12-08 Thread David Brownell
On Tuesday 08 December 2009, Øyvind Harboe wrote: > The changes you are proposing look *great* but I wonder if > they shouldn't be spread out over 0.4, 0.5 and possibly > also 0.6 to get enough feedback on the work along > the way. Assuming they all get done, they'd absolutely need to be spread ou

Re: [Openocd-development] multiple JTAG interfaces

2009-12-08 Thread Nico Coesel
-Oorspronkelijk bericht- Van: openocd-development-boun...@lists.berlios.de namens Øyvind Harboe Verzonden: di 12/8/09 22:33 Aan: Zach Welch CC: openocd-development Onderwerp: Re: [Openocd-development] multiple JTAG interfaces >I'm also concerned about such a major change >as introducing su

Re: [Openocd-development] multiple JTAG interfaces

2009-12-08 Thread Zach Welch
On Tue, 2009-12-08 at 22:33 +0100, Øyvind Harboe wrote: > I'm concerned about doing a lot more work on 0.4. I would > like to see what our track record is with this amount of changes > w.r.t. breakage. > > The changes you are proposing look *great* but I wonder if > they shouldn't be spread out ov

Re: [Openocd-development] multiple JTAG interfaces

2009-12-08 Thread Øyvind Harboe
I'm concerned about doing a lot more work on 0.4. I would like to see what our track record is with this amount of changes w.r.t. breakage. The changes you are proposing look *great* but I wonder if they shouldn't be spread out over 0.4, 0.5 and possibly also 0.6 to get enough feedback on the work

[Openocd-development] [patch 2/2] target: remove needless "extern"s

2009-12-08 Thread David Brownell
Most of these happened to be in the target.h file. Some of those are associated with symbols that could be removed at some point ... e.g. NVP_ASSERT/true and its sibling NVP_DEASSERT/false. --- Follow-on to the previous patch: don't needlessly export. src/target/cortex_a8.h |2 -- src/targe

[Openocd-development] [patch 1/2] target: move 'extern' decls to *.h files

2009-12-08 Thread David Brownell
The exception being declarations for drivers. Those should arguably be collected into tables by linker scripts, so the core doesn't need to know anything except how to cope with a set of target or ETM drivers ... but not today. --- Followup on an old request from Zach. :) src/target/arm.h

Re: [Openocd-development] [PATCH] Fix compilation error with gcc 4.4.1

2009-12-08 Thread David Brownell
> >> Any reason not to commit this anyone? > > > > obstreperousness ? > > What does that menas? :O http://m-w.com/dictionary/obstreperousness In this case, "just to be contrary" (or disagreeable). After all, he just asked for reasons ... not for ones worth paying attenion to! > > Not a good one

Re: [Openocd-development] multiple JTAG interfaces

2009-12-08 Thread David Brownell
On Monday 07 December 2009, Zach Welch wrote: > Hi all, > > The following list describes the things that might still be accomplished > before the 0.4.0-rc cycle starts. These features are all "mostly done" > in my tree; they work fine for me in limited testing. They should all > be safe incremen

Re: [Openocd-development] [PATCH] Fix compilation error with gcc 4.4.1

2009-12-08 Thread Rafael Campos
2009/12/8 David Brownell : > On Tuesday 08 December 2009, Ųyvind Harboe wrote: >> Any reason not to commit this anyone? > > obstreperousness ? What does that menas? :O > > Not a good one, but a reason.  ;) > > It's the less intrussive way to get compiled in my machine :) -- ___ Rafael Ca

Re: [Openocd-development] [PATCH] Fix compilation error with gcc 4.4.1

2009-12-08 Thread David Brownell
On Tuesday 08 December 2009, Øyvind Harboe wrote: > Any reason not to commit this anyone? obstreperousness ? Not a good one, but a reason. ;) ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/li

Re: [Openocd-development] [PATCH] Fix compilation error with gcc 4.4.1

2009-12-08 Thread Øyvind Harboe
Any reason not to commit this anyone? -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer ___ Openocd-development mailing list O

[Openocd-development] [PATCH] Fix compilation error with gcc 4.4.1

2009-12-08 Thread Rafael Campos Las Heras
Signed-off-by: Rafael Campos Las Heras --- src/jtag/drivers/bitq.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/jtag/drivers/bitq.c b/src/jtag/drivers/bitq.c index d04a39e..bffc475 100644 --- a/src/jtag/drivers/bitq.c +++ b/src/jtag/drivers/bitq.c @@ -21,6 +21,7 @

[Openocd-development] PIC32MX flash programming

2009-12-08 Thread Dubreuil, Thomas
Hi, I'd like to program the pic32 flash through JTAG. I've just discovered that openocd project support Mips core! I use an Amontec Jtag key. The command : flash write_image erase unlock rc0209.hex 0 ihex returns : No flash at address 0x1fc02ff4

Re: [Openocd-development] [PATCH 0/3] deferred 'init' and leaner 'help'

2009-12-08 Thread Spencer Oliver
Zachary T Welch wrote: > Hi all, > > These patches clean up the server and system startup. The first patch > factors the GDB server setup to be more conducive to deferred > initialization of targets (in a later series). > > The second provides the 'noinit' command which can be used in a script >

Re: [Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread Øyvind Harboe
On Tue, Dec 8, 2009 at 10:07 AM, David Brownell wrote: > On Tuesday 08 December 2009, Zach Welch wrote: >> As far as I'm concerned, you never need our sign-off for this file. :) >> >> --Z >> >> On Tue, 2009-12-08 at 09:39 +0100, Øyvind Harboe wrote: >> > Signed-off-by: Øyvind Harboe >> > --- >> >

Re: [Openocd-development] [PATCH 3/3] minidriver: fix inline capability of minidriver

2009-12-08 Thread Zach Welch
Do you really need to have the commands.[ch] changes here? If you can leave that alone, it would be preferred, as it doesn't appear to have anything to do with this patch. Also, you should not convert header file #includes in .c files to <> if the header is in the same directory. Indeed, that is

Re: [Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread Zach Welch
On Tue, 2009-12-08 at 01:07 -0800, David Brownell wrote: > On Tuesday 08 December 2009, Zach Welch wrote: > > As far as I'm concerned, you never need our sign-off for this file. :) > > > > --Z > > > > On Tue, 2009-12-08 at 09:39 +0100, Øyvind Harboe wrote: > > > Signed-off-by: Øyvind Harboe > >

Re: [Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread David Brownell
On Tuesday 08 December 2009, Zach Welch wrote: > As far as I'm concerned, you never need our sign-off for this file. :) > > --Z > > On Tue, 2009-12-08 at 09:39 +0100, Øyvind Harboe wrote: > > Signed-off-by: Øyvind Harboe > > --- > >  src/ecosboard.c |    4 > >  1 files changed, 0 insertions

Re: [Openocd-development] [patch 2/4] ARM: move opcode macros to

2009-12-08 Thread David Brownell
On Monday 07 December 2009, Nicolas Pitre wrote: > On Mon, 7 Dec 2009, David Brownell wrote: > > > Move the ARM opcode macros from , and a few > > Thumb2 ones from , to more appropriate homes > > in a new file. > > What about changing the names of a couple of those macros as well? I think that'

Re: [Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread Zach Welch
As far as I'm concerned, you never need our sign-off for this file. :) --Z On Tue, 2009-12-08 at 09:39 +0100, Øyvind Harboe wrote: > Signed-off-by: Øyvind Harboe > --- > src/ecosboard.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/src/ecosboard.c b/src/ecosb

Re: [Openocd-development] [PATCH 1/3] build: add build/src to include path

2009-12-08 Thread Zach Welch
I would say that the builddir should precede the srcdir. Happily, this should also generate a more minimal patch. Patches should touch as few lines as possible. Make all of them match the form: FOO = \ foo \ bar not FOO = foo \ bar The first form makes it p

[Openocd-development] [PATCH 1/3] build: add build/src to include path

2009-12-08 Thread Øyvind Harboe
This allows including generated include files. Signed-off-by: Øyvind Harboe --- src/Makefile.am |3 ++- src/flash/Makefile.am|3 ++- src/flash/nand/Makefile.am |3 ++- src/flash/nor/Makefile.am|3 ++- src/helper/Makefile.am |1 + src/jtag/Make

[Openocd-development] [PATCH 3/3] minidriver: fix inline capability of minidriver

2009-12-08 Thread Øyvind Harboe
Low latency low CPU processing power systems(embedded) will benefit greatly from being able to inline certain jtag_add_xxx() fn's. The trick is that this has to be done in such a way as to allow implementing an OpenOCD API with a shared library(eventually) on a PC hosted OpenOCD. Signed-off-by: Øy

[Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread Øyvind Harboe
Signed-off-by: Øyvind Harboe --- src/ecosboard.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/ecosboard.c b/src/ecosboard.c index 7d0c3d0..2e491c2 100644 --- a/src/ecosboard.c +++ b/src/ecosboard.c @@ -25,10 +25,6 @@ #include #include #include -#include -