Hi,
there seems to be a lot of other cleanup in this patch, I don't
know anything about this target really.
Would it make sense to split the patch into harmless cleanup
and then other patches for other changes?
This will improve your chances of someone reviewing your
changes and the community in
> normaly in shell we so
> if [ "x$1" = "xnosubmodule" ]; then
>
> to compatible with old shell too
I've committed Tormod's superior work where he really
cleaned up the bootstrap file...
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +
Very cool!
Perhaps you could split this patch into several patches with the first
patch to go in are with the most obvious fixes?
E.g. I was less sure about etb.c, but it might be fine...
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International
On 17:05 Wed 01 Jun , Øyvind Harboe wrote:
> How about this?
>
>
>
> --
> Øyvind Harboe
>
> Can Zylin Consulting help on your project?
>
> US toll free 1-866-980-3434 / International +47 51 87 40 27
>
> http://www.zylin.com/zy1000.html
> ARM7 ARM9 ARM11 XScale Cortex
> JTAG debugger and
simon qian wrote:
> I think maybe a better way is to download Versaloon USB_TO_XXX
> driver from SVN of vsprog.
> Because files under usbtoxxx directory is exactly the same as in vsprog.
> I'll check whether it is possible to add these code in sub-module.
Ok, but I think it would be fine to import
Hi,
I've added a verification after flashing, it runs the same algorithm as the
core{s flash module and compares the results.
This code runs when write_image is called. It does not work with
verify_image due to the workaround i implemented for the byte/word
addressing issue. Still working on this.
I think maybe a better way is to download Versaloon USB_TO_XXX driver from
SVN of vsprog.
Because files under usbtoxxx directory is exactly the same as in vsprog.
I'll check whether it is possible to add these code in sub-module.
2011/6/2 Peter Stuge
> simon qian wrote:
> > This patch update the
Please review - I'm not sure about more "drastic" changes (removing some
function calls), however all of them seem correct. I've tested it and it
now compiles on my system, the executable works (no functional testing).
Cheers!
From dbec85dc76abee585d59e0a1f406a81945bc2189 Mon Sep 17 00:00:00 20
Merged.
Thanks!
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
___
Openocd-d
Hi again!
I've completely modified my build environment. Now I'm using current
Ubuntu (on virtual machine) with most recent MinGW-W64 (32-bit for now,
currently setting up 64-bit). The error with sscanf() is gone, but new
GCC (4.7.0) is now more picky about non-used variables and it almost
ki
Tomek CEDRO wrote:
> > Please just use goto to handle errors.
>
> "goto hell" ;-)
>
> God function looks like:
>
> input o---[function]---o output
Agree.
> no other :-) no gotos :-) no globals :-) nice program flow :-) clean
> and self commentary code :-) good vibration :-) :-)
Indeed what y
simon qian wrote:
> This patch update the driver of Versaloon.
Thanks! I will review and try to do some testing soon.
//Peter
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-de
On Wed, Jun 1, 2011 at 7:05 PM, Peter Stuge wrote:
> Please just use goto to handle errors.
"goto hell" ;-)
God function looks like:
input o---[function]---o output
no other :-) no gotos :-) no globals :-) nice program flow :-) clean
and self commentary code :-) good vibration :-) :-)
--
CeD
Tomek CEDRO wrote:
> The new source code (after patching) have 6 functions doing almost
> the same: ft2232_init_ftd2xx(), ft2232_open_ftd2xx(),
> ft2232_init_libftdi(), ft2232_open_libftdi(), ft2232_init_sub(void),
> ft2232_init() and the header update ;-)
Student code galore.
> I can understa
From: Tormod Volden
- Do not specify -e twice.
- Use "which" instead of calling commands that might not exist.
- Fix bashism ("==" is C not sh)
- Carefully quote potentially empty variables
- Check command arguments before doing anything
- Rewrite argument checking to be more easily extensible
-
Hello again :-)
I have reviewed the patch.
The old source code had 3 functions ft2232_init() that can call
ft2232_init_libftdi() or ft2232_init_ftd2xx() depending on a ft2232
ftdi communication library available. This is pretty simple and
coherent.
The new source code (after patching) have 6 fu
From: Tormod Volden
- Do not specify -e twice.
- Use "which" instead of calling commands that might not exist.
- Fix bashism ("==" is C not sh)
- Carefully quote potentially empty variables
- Check command arguments before doing anything
- Rewrite argument checking to be more easily extensible
-
On Wed, Jun 1, 2011 at 3:06 PM, Øyvind Harboe wrote:
> I haven't read over this patch. Do you think it is ready or does it need work?
Hello :-) For me lots of things should be changed/reorganized anyway
so I don't really want to interfere at this stage until I know I have
time and resources to wo
Hi Tomek,
I haven't read over this patch. Do you think it is ready or does
it need work?
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and
How about this?
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
From f81b65e167dfe137d946d0add26d74b3e9ad8fce Mon Sep 17 0
On Wed, Jun 1, 2011 at 4:24 PM, Øyvind Harboe wrote:
> Would you mind formulating a patch?
>
> It would be greatly appreciated.
>
> Thanks!
Feel free to cut and paste from my e-mail. I was just looking at it
through gitweb and I don't have any git tree etc set up here and now.
But I can come back
On Wed, Jun 1, 2011 at 7:22 AM, Øyvind Harboe wrote:
> Merged very slightly different version that prints out error message
> upon invalid argument.
>From the commit:
+if [ $1 == nosubmodule ]; then
Note that if $1 is empty, some (most) shells will see just [ ==
nosubmodule ] and fail. So always
Would you mind formulating a patch?
It would be greatly appreciated.
Thanks!
2011/6/1 Tormod Volden :
> On Wed, Jun 1, 2011 at 7:22 AM, Øyvind Harboe wrote:
>> Merged very slightly different version that prints out error message
>> upon invalid argument.
>
> From the commit:
> +if [ $1 == nosubm
Hello,
is anyone working on such a target? There are arm920 and arm926ejs
targets, but arm922 is not there. arm922 seems to be very similar with
arm920.
Regards,
Yegor
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lis
Hi Drasko
> Just for the curiosity, n patch 1 :
> + /* mips32_pracc_fastdata_xfer requires uint32_t in host endianness, */
> + /* but byte array represents target endianness */
>
> Where does this comment comes from ? Pure experience ? Can you back it up ?
"mips32_pr
25 matches
Mail list logo
