Re: [Openocd-development] [PATCH] Fix unused variable warnings (errors) detected with GCC 4.7.0

2011-06-02 Thread Øyvind Harboe
Very cool! Perhaps you could split this patch into several patches with the first patch to go in are with the most obvious fixes? E.g. I was less sure about etb.c, but it might be fine... -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International

Re: [Openocd-development] [PATCH] Fix unused variable warnings (errors) detected with GCC 4.7.0

2011-06-02 Thread Freddie Chopin
On 2011-06-02 08:12, Øyvind Harboe wrote: Perhaps you could split this patch into several patches with the first patch to go in are with the most obvious fixes? E.g. I was less sure about etb.c, but it might be fine... Any hints on the method to split such commited change into several

Re: [Openocd-development] [PATCH] Fix unused variable warnings (errors) detected with GCC 4.7.0

2011-06-02 Thread Øyvind Harboe
On Thu, Jun 2, 2011 at 10:11 PM, Freddie Chopin freddie_cho...@op.plwrote: On 2011-06-02 08:12, Øyvind Harboe wrote: Perhaps you could split this patch into several patches with the first patch to go in are with the most obvious fixes? E.g. I was less sure about etb.c, but it might be

[Openocd-development] [PATCH] Fix unused variable warnings (errors) detected with GCC 4.7.0

2011-06-01 Thread Freddie Chopin
Please review - I'm not sure about more drastic changes (removing some function calls), however all of them seem correct. I've tested it and it now compiles on my system, the executable works (no functional testing). Cheers! From dbec85dc76abee585d59e0a1f406a81945bc2189 Mon Sep 17 00:00:00