Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-10 Thread luca ellero
On 09/02/2011 10.57, Øyvind Harboe wrote: Hi Aaron, On Wed, Feb 9, 2011 at 10:54 AM, Aaron Carrollaar...@cse.unsw.edu.au wrote: Hi all, I think the consensus on this issue is that AP handling could be improved. Until someone has the motivation to fix it properly, can this patch be applied?

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-10 Thread Øyvind Harboe
Merged. Thanks! -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer ___

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-09 Thread Aaron Carroll
Hi all, I think the consensus on this issue is that AP handling could be improved. Until someone has the motivation to fix it properly, can this patch be applied? A9 reset is broken without it. Thanks, -- Aaron ___ Openocd-development mailing list

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-09 Thread Øyvind Harboe
Hi Aaron, On Wed, Feb 9, 2011 at 10:54 AM, Aaron Carroll aar...@cse.unsw.edu.au wrote: Hi all, I think the consensus on this issue is that AP handling could be improved. Until someone has the motivation to fix it properly, can this patch be applied? A9 reset is broken without it. What I

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-07 Thread luca ellero
On 07/02/2011 3.54, Aaron Carroll wrote: On 04/02/11 17:31, Mathias K. wrote: Hello, On 04.02.2011 01:38, Aaron Carroll wrote: At a high level, I think it makes sense for functions to be explicit about selecting an AP... I don't see any advantage to a default. I don't know if the AP always

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-07 Thread Mathias K.
Hello, On 07.02.2011 09:27, luca ellero wrote: On 07/02/2011 3.54, Aaron Carroll wrote: On 04/02/11 17:31, Mathias K. wrote: Hello, On 04.02.2011 01:38, Aaron Carroll wrote: At a high level, I think it makes sense for functions to be explicit about selecting an AP... I don't see any

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-06 Thread Aaron Carroll
On 04/02/11 17:31, Mathias K. wrote: Hello, On 04.02.2011 01:38, Aaron Carroll wrote: At a high level, I think it makes sense for functions to be explicit about selecting an AP... I don't see any advantage to a default. I don't know if the AP always equal in a complete architecture or is

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-06 Thread Mathias K.
Hello, On 07.02.2011 03:54, Aaron Carroll wrote: On A8/omap35xx and A9/omap44xx, the CPU CoreSight component is on AP 0 (an APB-AP). However, for both these platforms we do memory accesses on AP 1, which is an AHB-AP. One advantage of this is the core does not need to be halted to access

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-03 Thread Aaron Carroll
On 03/02/11 17:33, Mathias K. wrote: Hello, i think it's better to fix ahbap_debugport_init. I have the same wrong default AP on cortex_r4. /* Default MEM-AP setup. * * REVISIT AP #0 may be an inappropriate default for this. * Should we probe, or take a hint from the caller? * Presumably we

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-03 Thread Mathias K.
Hello, On 04.02.2011 01:38, Aaron Carroll wrote: At a high level, I think it makes sense for functions to be explicit about selecting an AP... I don't see any advantage to a default. I don't know if the AP always equal in a complete architecture or is this done at cpu vendor level. For mem

[Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-02 Thread Aaron Carroll
Save, select and restore AP in cortex_a9_step and cortex_a9_init_debug_access. Fixes a bug where the wrong AP is selected after a reset. Signed-off-by: Aaron Carroll aar...@cse.unsw.edu.au --- src/target/cortex_a9.c | 26 -- 1 files changed, 20 insertions(+), 6

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-02 Thread Øyvind Harboe
Not my strong suit... Any objections? -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer

Re: [Openocd-development] [PATCH] cortex_a9: fix dap_ap_select() usage

2011-02-02 Thread Mathias K.
Hello, i think it's better to fix ahbap_debugport_init. I have the same wrong default AP on cortex_r4. /* Default MEM-AP setup. * * REVISIT AP #0 may be an inappropriate default for this. * Should we probe, or take a hint from the caller? *