Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-23 Thread Øyvind Harboe
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openoc

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-20 Thread Michel JAOUEN
Harboe Cc: Michel JAOUEN; openocd-development@lists.berlios.de Subject: Re: [Openocd-development] [PATCH] kinetis cpu flash driver Hello, i prefer something like this (i don't want to start a goto discussion): if ( tap->hasidcode && (dap_syssec_filter_data[i].idcode == tap->idcod

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-19 Thread Mathias K.
Hello, i prefer something like this (i don't want to start a goto discussion): if ( tap->hasidcode && (dap_syssec_filter_data[i].idcode == tap->idcode) ) but we should be sure that idcode is initialized with an invalid value like zero but independent of the hasidcode flag. Regards, Mathias

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-19 Thread Øyvind Harboe
I'll let it cool off for a few days. Please give word if further work is required and we should submit an updated patch. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-developm

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-19 Thread Michel JAOUEN
, September 17, 2011 2:25 PM To: Mathias K. Cc: openocd-development@lists.berlios.de Subject: Re: [Openocd-development] [PATCH] kinetis cpu flash driver Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-17 Thread Øyvind Harboe
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openoc

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-17 Thread Mathias K.
Hello, i have worked on the issues, please let me know if there was something that i have not picked up. Regards, Mathias Am 16.09.2011 10:00, schrieb Øyvind Harboe: > First of all, overall I think the code looks good! > > Some nit-picking below. > > The OpenOCD error handling is modeled up

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-16 Thread Øyvind Harboe
First of all, overall I think the code looks good! Some nit-picking below. The OpenOCD error handling is modeled upon exception handling, report error in place and then just propagate errors (exceptions) without changing the return value. 1. Switch to LOG_ERROR. +FLASH_BANK_COMMAND_HANDLER(kin

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-12 Thread Mathias K.
No problem. Am 12.09.2011 21:49, schrieb Øyvind Harboe: > Please squash the patches together and repost if they do belong in > the same patch. > > Thanks! > >From 1b17ccce801ff322ff5372207d82fb8827b4cbcf Mon Sep 17 00:00:00 2001 From: Mathias K. Date: Mon, 12 Sep 2011 21:58:49 +0200 Subject: [

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-12 Thread Øyvind Harboe
Please squash the patches together and repost if they do belong in the same patch. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-deve

Re: [Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-12 Thread Mathias K.
Hello, this patch removes the test code used to verify the functionality. Regards, Mathias Am 12.09.2011 16:17, schrieb Mathias K.: > Hello, > > i have done some work on the kinetis cpu flash driver. Erase,write and read > protection works. > > > Regards, > > Mathias >From 3a4d6a735680b00

[Openocd-development] [PATCH] kinetis cpu flash driver

2011-09-12 Thread Mathias K.
Hello, i have done some work on the kinetis cpu flash driver. Erase,write and read protection works. Regards, Mathias >From 09e1902067fac38e39564c538b6a125e3a0254b6 Mon Sep 17 00:00:00 2001 From: Mathias Kuester Date: Mon, 12 Sep 2011 16:11:06 +0200 Subject: [PATCH] kinetis cpu flash driver