Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-07 Thread Freddie Chopin
Hi! I've investigated the remaining files a bit and... found nothing that could still be unused inside them... I post the patch with remaining changes, tell me what the errors are in your build environment. 4\/3!! From dcabbc362e50ce9c13acf71eb3516128b25d10fe Mon Sep 17 00:00:00 2001 From:

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-07 Thread Øyvind Harboe
It builds with normal build options, but fails with -O3: CFLAGS=-O3 ./configure --enable-dummy make clean make -s = libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../src -DPKGDATADIR=\/usr/local/share/openocd\ -I../../jimtcl -I../../jimtcl -O3 -Wall

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-07 Thread Øyvind Harboe
Strike that. I pushed a fix for that -O3 warning and that -O3 warning wasn't related to your patch. -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-04 Thread Øyvind Harboe
usbprog.c is clearly broken, I don't think this warning should be fixed as that would be shuffling a bug under the carpet. I've pushed most of the other fixes, but you'll need to run through two versions of GCC or try -O3 to get the residual warnings I think. Try: CFLAGS=-O3 -g ./configure

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-04 Thread Freddie Chopin
On 2011-06-04 09:48, Øyvind Harboe wrote: usbprog.c is clearly broken, I don't think this warning should be fixed as that would be shuffling a bug under the carpet. Maybe, but it compiles this way (; To me it seems that there was some old way of making things, then new way come and somebody

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-04 Thread Øyvind Harboe
Hi Freddie, I just wanted to merge those changes that were ready to go in as that was all I have time for this morning. Some of your changes broke compiling on gcc 4.4.3(generated more warnings), so I didn't want to put them in there yet. I think gcc 4.4.3 discovered more unused code once you

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-04 Thread Freddie Chopin
On 2011-06-04 10:30, Øyvind Harboe wrote: I just wanted to merge those changes that were ready to go in as that was all I have time for this morning. Some of your changes broke compiling on gcc 4.4.3(generated more warnings), so I didn't want to put them in there yet. I think gcc 4.4.3

Re: [Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-04 Thread Øyvind Harboe
Ok, I'll wait then. Maybe I'll investigate on my own - just 4 files so maybe I'll find something. To create the residual commit: git fetch origin git rebase origin/master = your commits will now contain only the residual changes. -- Øyvind Harboe Can Zylin Consulting help on your project?

[Openocd-development] [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes

2011-06-03 Thread Freddie Chopin
From 47280c11e16f2136ef4c4c7ffd89466985cc5faa Mon Sep 17 00:00:00 2001 From: Freddie Chopin freddie_cho...@op.pl Date: Fri, 3 Jun 2011 22:13:35 +0200 Subject: [PATCH 2/2] Fix unused variable warnings (errors) detected with GCC 4.7.0 - dubious fixes --- src/jtag/drivers/usbprog.c |6 --