Re: [Openocd-development] [PATCH 2/2] config: simplify default value handling of at91cap7a-stk-sdram

2010-12-19 Thread Øyvind Harboe
>> What do you think about the new structure? > > By structure, if you mean default value handling, > I didn't like the complex if/then/... stuff, so > count the subroutine a win, even if it adds a > potentially confusing OpenOCD-only mechanism. Note that it's backwards compatible. You can employ

Re: [Openocd-development] [PATCH 2/2] config: simplify default value handling of at91cap7a-stk-sdram

2010-12-19 Thread David Brownell
--- On Sun, 12/19/10, Øyvind Harboe wrote: > > > A good simplification would be to remove every > > non-BIG endianness  setting. > The big/little endian issue is orthogonal to how we > organize the config files. But not to $SUBJECT of this specific thread. > > What do you think about th

Re: [Openocd-development] [PATCH 2/2] config: simplify default value handling of at91cap7a-stk-sdram

2010-12-19 Thread Øyvind Harboe
On Sun, Dec 19, 2010 at 5:22 PM, David Brownell wrote: > > > --- On Sun, 12/19/10, Øyvind Harboe wrote: > > > >> -if { [info exists ENDIAN] } { >> -   set  _ENDIAN $ENDIAN >> -} else { >> -   set  _ENDIAN little > > > > A good simplification would be to remove every > non-BIG endianness  setting.

Re: [Openocd-development] [PATCH 2/2] config: simplify default value handling of at91cap7a-stk-sdram

2010-12-19 Thread David Brownell
--- On Sun, 12/19/10, Øyvind Harboe wrote: > -if { [info exists ENDIAN] } { > -   set  _ENDIAN $ENDIAN > -} else { > -   set  _ENDIAN little A good simplification would be to remove every non-BIG endianness setting. When not specified, the OpenOCD default is "little". Including "little"

[Openocd-development] [PATCH 2/2] config: simplify default value handling of at91cap7a-stk-sdram

2010-12-19 Thread Øyvind Harboe
Illustration of the new config script handling scheme. Signed-off-by: Øyvind Harboe --- tcl/board/at91cap7a-stk-sdram.cfg | 297 ++--- 1 files changed, 143 insertions(+), 154 deletions(-) diff --git a/tcl/board/at91cap7a-stk-sdram.cfg b/tcl/board/at91cap7a-stk-