Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-07-02 Thread Marc Pignat
On Friday 02 July 2010 12:15:06 Øyvind Harboe wrote: > I'm going to leave it to you to follow up and make the decision on whether > to revert here. Hi all! It seems that 2/2 has introduced problems. It seemed trivial to me, but finally it isn't! I think we should revert it. Best regards Marc _

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-07-02 Thread Øyvind Harboe
I'm going to leave it to you to follow up and make the decision on whether to revert here. I was just committing stuff based upon a consensus in the list that this was the right direction to go, I don't know this code very well... -- Øyvind Harboe US toll free 1-866-980-3434 / International +4

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-07-02 Thread Spencer Oliver
On 17/06/2010 09:16, Marc Pignat wrote: --- src/jtag/drivers/ft2232.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/jtag/drivers/ft2232.c b/src/jtag/drivers/ft2232.c index bc8463e..9d40b1c 100644 --- a/src/jtag/drivers/ft2232.c +++ b/src/jtag/

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-07-01 Thread Spencer Oliver
On 01/07/2010 08:34, Øyvind Harboe wrote: merged both patches. Thanks! Just got back from various travels. I have committed a build fix for this patchset. patch2 also breaks when using the ftdi driver, not looked into why yet. Cheers Spen ___ Ope

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-07-01 Thread Øyvind Harboe
merged both patches. Thanks! -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer ___ Openocd-development mailing list Openocd-de

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-30 Thread Øyvind Harboe
Would you mind posting a link to both patches? I'm not really following this interface development, just doing the mechanics of merging patches as approperiate. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-30 Thread Jon Povey
David Brownell wrote: >> It has gotten positive testing feedback so far, > > I'd like clarification on that: there were two > patches. This #2/2 was more invasive, and is > presumably what was tested. But both cleanups > should likely get merged. For my part, I applied both patches and tested.

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-30 Thread David Brownell
> I'll let this cool off for a few days > and then I'll commit it. Great; I wish I could do that but my current patches-from-email situation is malfunctioning. > It has gotten positive testing feedback so far, I'd like clarification on that: there were two patches. This #2/2 was more invasi

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-30 Thread Øyvind Harboe
I'll let this cool off for a few days and then I'll commit it. It has gotten positive testing feedback so far, so anyone with objections should speak now. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-30 Thread Laurent Gauch
>/ These read OK, I thought, but I'm not in a />/ position right now to review (in detail) or />/ verify either patch. />/ />/ Could someone with an FTDI-based adapter />/ please try these out and verify them? Then />/ maybe have a committer commit them, if they />/ ideed check out? / Works for

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-29 Thread Jon Povey
David Brownell wrote: > These read OK, I thought, but I'm not in a > position right now to review (in detail) or > verify either patch. > > Could someone with an FTDI-based adapter > please try these out and verify them? Then > maybe have a committer commit them, if they > ideed check out? Works

Re: [Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-29 Thread David Brownell
These read OK, I thought, but I'm not in a position right now to review (in detail) or verify either patch. Could someone with an FTDI-based adapter please try these out and verify them? Then maybe have a committer commit them, if they ideed check out? The first one looked pretty obvious (cleani

[Openocd-development] [RFC, PATCH 2/2] ft2232: simplify ft2232_read_scan

2010-06-17 Thread Marc Pignat
--- src/jtag/drivers/ft2232.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/jtag/drivers/ft2232.c b/src/jtag/drivers/ft2232.c index bc8463e..9d40b1c 100644 --- a/src/jtag/drivers/ft2232.c +++ b/src/jtag/drivers/ft2232.c @@ -714,23 +714,24 @@ stati