Re: [Openocd-development] [RFC/PATCH] CFI: simplify bufferwsize computation

2010-03-25 Thread Øyvind Harboe
I'm a bit worried about applying this patch, it does look sensible to me, but I don't know that cfi.c code very well... Perhaps if you improved the comments or even made a fn, you would attract comments/reviews from others who know the code better? -- Meet us in Paris at rts EMBEDDED SYSTEMS 2

Re: [Openocd-development] [RFC/PATCH] CFI: simplify bufferwsize computation

2010-03-25 Thread Antonio Borneo
On Thu, Mar 25, 2010 at 2:49 PM, Øyvind Harboe wrote: > Did you test it? The patch changes 3 parts but, I have executed and tested only 2 of them. I cannot test the function cfi_spansion_write_words() since don't have boards with such device. Anyway, in the original code the same algorithm is re

Re: [Openocd-development] [RFC/PATCH] CFI: simplify bufferwsize computation

2010-03-24 Thread Øyvind Harboe
Did you test it? -- Meet us in Paris at rts EMBEDDED SYSTEMS 2010 - March 30. and April 1. http://www.zylin.com/events_rts.html Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash progr

[Openocd-development] [RFC/PATCH] CFI: simplify bufferwsize computation

2010-03-24 Thread Antonio Borneo
Hi, in src/flash/nor/cfi.c the mathematics around computing "bufferwsize" variable is quite obscure. Current code is the result of one year old patch to introduce multi-chip flash support. In the attached patch I try to simplify the code and comment what the variable is and how it is computed. Ple