Re: [Openocd-development] [patch] xsvf.c: support XSDRB, XSDRC, XSDRE commands

2010-01-27 Thread Florian Echtler
I was looking at this, and it had a few style problems. Here's a slightly cleaned-up version of your code ... untested. I suggest you eyeball what I changed, and update your latest patch ... Hello David, I've been reading the XSVF spec a bit more, and I'm pretty sure that the handling of

Re: [Openocd-development] [patch] xsvf.c: support XSDRB, XSDRC, XSDRE commands

2010-01-22 Thread Florian Echtler
Hello again, I have to replay an XSVF file using openocd which uses the XSDRB, XSDRC and XSDRE commands. I'm definitely not a JTAG expert, but I've hacked together a patch to support these three commands. It seems to work on my Spartan3A device, though I haven't done a lot of testing yet.

Re: [Openocd-development] [patch] xsvf.c: support XSDRB, XSDRC, XSDRE commands

2010-01-22 Thread David Brownell
On Friday 22 January 2010, Florian Echtler wrote: - is it acceptable to handle XSDRB and XSDRC identically? AFAICT the TAP should be in Shift-DR state anyway at that point? If it were, there wouldn't be two distinct opcodes. :) Xilinx XAPP503 (defining XSVF) says in Appendix B: XSDRB

[Openocd-development] [patch] xsvf.c: support XSDRB, XSDRC, XSDRE commands

2010-01-20 Thread Florian Echtler
Hello everyone, I have to replay an XSVF file using openocd which uses the XSDRB, XSDRC and XSDRE commands. I'm definitely not a JTAG expert, but I've hacked together a patch to support these three commands. It seems to work on my Spartan3A device, though I haven't done a lot of testing yet.