[Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Øyvind Harboe
One problem about jtag_add_end_state() is that it's effectively setting a global variable. This makes it hard to tell, reading some code, what is expected to happen after a JTAG scan. Some other calling code invoked jtag_add_end_state() with some end state. Other than running the debugger, I don

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Magnus Lundin
I have been giving this a lot of thought, and I would like to suggest a compromise :) I dont have the code with me right now so some of some function names ´might be a bit off but the idea should be clear. > One problem about jtag_add_end_state() is that it's effectively > setting a global variab

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Øyvind Harboe
On Wed, May 13, 2009 at 4:21 PM, Magnus Lundin wrote: > I have been giving this a lot of thought, and I would like to suggest a > compromise :) > > I dont have the code with me right now so some of some function names > ´might be a bit off but the idea should be clear. > >> One problem about jtag_

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread David Brownell
On Wednesday 13 May 2009, Magnus Lundin wrote: > Not always, TAP_INVALID is really TAP_DONTCARE I was wondering about that. Someone should rename it so it's no longer nonsense. ___ Openocd-development mailing list Openocd-development@lists.berlios.de ht

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Øyvind Harboe
On Wed, May 13, 2009 at 4:40 PM, David Brownell wrote: > On Wednesday 13 May 2009, Magnus Lundin wrote: >> Not always, TAP_INVALID is really TAP_DONTCARE > > I was wondering about that.  Someone should rename it > so it's no longer nonsense. The point is to do away with "don't care", "default" an

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread David Brownell
On Wednesday 13 May 2009, Øyvind Harboe wrote: > >> Not always, TAP_INVALID is really TAP_DONTCARE > > > > I was wondering about that.  Someone should rename it > > so it's no longer nonsense. > > The point Make that: "another" point. > is to do away with "don't care", "default" and global var

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Magnus Lundin
Øyvind Harboe wrote: > On Wed, May 13, 2009 at 4:40 PM, David Brownell wrote: > >> On Wednesday 13 May 2009, Magnus Lundin wrote: >> >>> Not always, TAP_INVALID is really TAP_DONTCARE >>> >> I was wondering about that. Someone should rename it >> so it's no longer nonsense. >>

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Øyvind Harboe
On Wed, May 13, 2009 at 6:19 PM, Magnus Lundin wrote: > Øyvind Harboe wrote: >> On Wed, May 13, 2009 at 4:40 PM, David Brownell wrote: >> >>> On Wednesday 13 May 2009, Magnus Lundin wrote: >>> Not always, TAP_INVALID is really TAP_DONTCARE >>> I was wondering about that.  Someone should

Re: [Openocd-development] Remove jtag_add_end_state()?

2009-05-13 Thread Øyvind Harboe
On Wed, May 13, 2009 at 6:11 PM, David Brownell wrote: > On Wednesday 13 May 2009, Řyvind Harboe wrote: >> >> Not always, TAP_INVALID is really TAP_DONTCARE >> > >> > I was wondering about that.  Someone should rename it >> > so it's no longer nonsense. >> >> The point > > Make that:  "another" po